Search for url encoded portal url and replace with {{portalBaseUrl}} property about solution.js

[MikeTschudi]

@chris-fox, I think that there may be other swizzling needed. In this case, it's for items referenced by the StoryMap. With the example "Hello World" StoryMap, it's references to the "Citizen Problem Manager" WMA and "Favorite Redlands Restaurant" Form, respectively:

These referenced items are also not appearing in the StoryMap's dependencies list.

When a group containing the dependencies is converted into a Solution, swizzling occurs. It's only if we convert a single StoryMap into a Solution that we're not picking up the dependencies. How important is this case, please?

[chris-fox]

@MikeTschudi, I am good with the current behavior that we only discover the dependencies of the story map if they are also shared in the group that is used to create the solution item. Thanks for confirming.

[chris-fox]

@MikeTschudi, I am curious how you handled de-templatizing back to an encoded url? Right now in the story map we are templatizing both the encoded and unencoded url with the same variable {{portalBaseUrl}}, how do you know during the de-templatizing whether the url needs to be encoded or not? Are we just doing it special for StoryMaps?

I was wondering if we should create a new variable like {{portalBaseUrlEncoded}} so it is explicit in the template and the logic can be applied to all item types.

[MikeTschudi]

@chris-fox, because StoryMaps have their own package, I made the changes only there.

When de-templatizing, I chose to look in the data section for the StoryMap for the pattern portalUrl=https://, which only appears in the encoded URLs (this is after the standard de-templatizing code has replaced ${portalUrl} throughout). These are replaced with the encoded version portalUrl=https%3A%2F%2F.

[chris-fox]

What do you think of making this more generic and apply to all item types via a unique variable? I am just wondering if we can handle the encoded portal url more broadly in case this comes up in other items as well.

[MikeTschudi]

Let's please wait until that situation arises so that we know what pattern(s) we need to match.

[chris-fox]

verified