Coder Social home page Coder Social logo

Comments (17)

csmoore avatar csmoore commented on August 22, 2024

Update - updated table and issue name to reflect fixes in 7/21/14 drop & any newly noticed issues (ex.a couple notional labels still visible on Control Measures).

Resolved in this drop:

Id/Filename Symbol Set EntityCode Name Issue
25130300 Control Measures(25) 130300 Command and Control Points : Checkpoint Should be "CKP" (instead of "AMN")

Graphic 25140200 removed from list of icon exports and clarified that not a drawn symbol.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Just a couple of sample images to hopefully clarify 2 of the items from original issue above:

Neutral central icons can't be seen-they are touching/past/obscured by frame:

10XXXX98_2:
10xxxx98_2

10121103_2:
10121103_2

Non friendly central icons don't touch frame:

10120402 Friendly vs. Unknown versions:
10120402_1

10120402_0

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

2 additional (minor) issues I noticed are:

  1. The line width for the reality/present version of the frame outlines seems to have gotten thinner recently (shown below compared to the Exercise version of the frame)
  2. The command echelon amplifier ("++") is hard to see compared to the other echelon amplifiers

sampleimage
sampleimage2
sampleimage3

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Any of these addressed in latest/8/26/14 MIL_STD_2525D_Symbols.zip ?

Might be a good idea to add a change-log to MIL_STD_2525D_Symbols.zip with a quick synopsis of the changes when a new version is released.

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

@mepler: can you please look into these various issues and check or correct as needed?

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

I think the only additional thing (in addition to the ones still open above) I've noticed in the new set (10/20/14) is this one went a bit pear-shaped:

20_120309 :

image

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

@abouffard - and how that one (20_120309) looks on the map - so we will probably need you to manually fix this one or otherwise workaround:

image

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

@mepler: please review and correct the indicated symbol in your master.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Looks like there are still some ArialMT fonts in the latest batch also (which seems to be an unmapped font on my system) - to find these from DOS:

> findstr /s /c:"ArialMT" *.svg

from joint-military-symbology-xml.

mepler avatar mepler commented on August 22, 2024

'ArialMT' has been replaced with 'sans-serif' in the master SVG files.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Looks like the issues still exist with these 2 symbols in the latest update:

https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/MIL_STD_2525D_Symbols/Appendices/Land/20120309.svg

https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/MIL_STD_2525D_Symbols/Appendices/Land/20120902.svg

from joint-military-symbology-xml.

mepler avatar mepler commented on August 22, 2024

The blob effect with 20120309.svg was caused by the line representing the 'spillage' in the image. The issue has been corrected.

20120902.svg has been updated and should now display correctly.

Update forthcoming.

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

Thanks @mepler Just send the corrected svg files to me and I'll put them into my next pull request.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

@abouffard - can you update the status of this issue and let me know if it is ready to verify?

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

A new document has been created at https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/KNOWN_ISSUES.md in #139 , designed to track SVG issues. I have reviewed the output from the Runtime dictionary image dump project and passed the resulting PNG files to @mepler for review. The SVG issues above that are not still logged in https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/KNOWN_ISSUES.md have been fixed and are reflected in what we have now. @mepler is aware of the still open issues and is working on them, together with fixing the issue we reported on varying sizes for some point control measures.

My recommendation is that @csmoore independently verify that those issues above not still listed in https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/KNOWN_ISSUES.md have indeed been addressed, and that we then close this issue and continue tracking new issues, still open issues, and the evolution of changes to the various SVG file issues in https://github.com/Esri/joint-military-symbology-xml/blob/master/svg/KNOWN_ISSUES.md.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Thanks for checking these - that new discrepancies/KNOWN_ISSUES.md/readme looks great btw - having those graphics there in a table makes a tremendous difference, nice work.

Just 2 notes:

  1. Add a link to this doc in the main folder readme
  2. For those grey background ones I think Mike said that was intentional/by design

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

He did on the grey ones, but I thought the intent was that the grey backed the area inside the shape of the symbols, not the "canvas" behind the symbol. I'm asking the Navy for confirmation.

from joint-military-symbology-xml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.