Coder Social home page Coder Social logo

Comments (7)

abouffard avatar abouffard commented on August 22, 2024

Fixed in PR #97. Please test and verify @csmoore

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Thanks - much easier to see/validate which ones are missing now.

Are the 3 remaining "does not exist" symbols already recorded as issues somewhere? (like #16 ?)

{Symbols_Root}\Appendices\Space\05111900
{Symbols_Root}\Appendices\ControlMeasures\25140200
{Symbols_Root}\Appendices\ControlMeasures\25240805

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

@abouffard - I never heard back on question above so I'll just add these 3 to the new Image Discrepancies Issue #98 so we can close this

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

@abouffard - I just had a look and 1 of those 2 remaining "does not exist" icons seem to be errors in the XML - can you fix please. Reopening this issue and assigning to @abouffard.

Incorrect Icons files:
Appendices\ControlMeasures\25240805 --> should be 25240805a

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

Fixed in PR merge #100. Also addressed 25140200. We should have no more missing svg files. @csmoore : please review, confirm, and close at your leisure.

from joint-military-symbology-xml.

csmoore avatar csmoore commented on August 22, 2024

Updated files looks good & comments were very useful to clarifying the current standard depiction vs. reality (I wonder if we shouldn't do something similar-add a similar comment to clarify the 3 boundary line depictions on the boundary line entry?)

from joint-military-symbology-xml.

abouffard avatar abouffard commented on August 22, 2024

Thanks. The general inclusion of Description and Remarks attributes in JMSML were intended for things like this. Description to essentially help generally describe the doctrine behind the use of a given symbol, the Remarks for information that might be exceptional/unexpected/particularly unusual about a given symbol, or mainly just information about that symbol that would benefit someone implementing it in a solution. Perhaps someday our symbol editing/browser UIX can make use of more of this kind of metadata. Perhaps over time we'll see other contributors offering to provide details for some of these attributes. They would also then make good informative content in any document generated from the XML using style sheets.

from joint-military-symbology-xml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.