Comments (8)
It actually can check the actual path and only notes really missing image files, IF you configure settings in the jmsml.config file with your actual image information. I have a custom version of jmsml.config on my machine that I use for that purpose, but since its hard coded to my settings its not the version in the repo. I haven't written explicit documentation to explain this yet, but will. It is alluded to in the current jmsml.config itself, if you examine it.
For purposes of documenting it here:
SVGHome = the actual path of your svg files, currently set to point to the relative location of the svgs in the repo, but would need to be changed if the user wanted to move those or point to a different version of the svgs.
GraphicRoot = the string prepended to the paths that are written out in the image file, name, category, tag exports.
GraphicExtension = the file extension used when the export code tests for the existence of your image files, so you can use this to test existence of the svgs or converted emfs. Its the extension written out in the first column of the image file, names, category, tags exports..
<ETLConfig DomainSeparator=" : " PointSize="32" SVGHome ="..\..\..\..\..\svg\MIL_STD_2525D_Symbols" GraphicRoot="{Symbols_Root}" GraphicHome="path_that_equates_to_your_{Symbols_Root}_goes_here" GraphicExtension="emf">
I made the graphic extension variable because the examples I saw had both svg and emf extensions. I don't have emfs on my machine, just the JMSML svgs, so the config file is currently "generic" and needs editing by the user, and the current samples reflect that. That's why the samples (note I think of these as "samples", not real export data, which the user should generate for themselves, IMHO) show all files missing. .
from joint-military-symbology-xml.
If it already has this capability & you know how to configure it then maybe when you get an opportunity you update the files at https://github.com/Esri/joint-military-symbology-xml/tree/master/samples/imagefile_name_category_tags
It would be useful if folks could just use these files "as-is" from the repo without needing to configure/compile (which is the primary goal of these suggested improvements). It is a useful output.
I know for me personally I would prefer if the github-posted version notes column didn't have a bunch of spurious "'icon is MAIN'', "image file does not exist" & just had the conditions we needed to pay attention to/check - this could have potentially helped us find some problems earlier.
from joint-military-symbology-xml.
The rest of these are just ideas for improvements/testing, but I would like that ""image file does not exist" removed from the example/sample outputs (and only show up there if the expected image file really doesn't exist - so we know this important case) - let me know if I need to open a separate issue for that...
from joint-military-symbology-xml.
Fixed in PR #97
from joint-military-symbology-xml.
@abouffard I just noticed this was assigned to me - am I supposed to verify? (but it looks like only item 2 or 2iii from the original issue is done - correct?)
from joint-military-symbology-xml.
Yes, I just wanted you to be aware that you might want to track these as they got checked off. But of your list of suggestions just the file checking (against the svg files in the repo) have been implemented in the sample exports, because Mike has supplied another set of files and I wanted to make sure nothing was missing. Hang on verifying anything for now though because I am about to pull/merge the newest files, including new dashed frames for planned status support.
from joint-military-symbology-xml.
Update: Changed issue to Task List & plz see if this can be included in sprint
from joint-military-symbology-xml.
Closing this one, the major things I wanted accomplished from above got done in #108 (the other 2 item are optional and just ideas for future minor improvements)
from joint-military-symbology-xml.
Related Issues (20)
- 18-011-MC Add Battle Handover Line Control Measure
- 18-012-MC Add Forward Passage of Lines as a Tactical Mission Task
- 18-013-MC Add Rearward Passage of Lines as a Tactical Mission Task
- 18-014-MC Add Control Point Control Measure
- 18-015-AR Add Human Resources Symbology
- 18-011-UK Boundary Amplifier Clarification
- 18-012-UK Lines Amplifiers Clarification
- 18-XXX-UK SCP Approval Clarification
- 18-014-UK Planned Control Measure Symbol ID
- Draw Rules for Antitank Ditch and Wall HOT 6
- Empty Paths in SVGs HOT 1
- Additional Affiliations HOT 1
- Ship Area of Interest - Questions HOT 1
- Variation in SVG size for Control Measures and METOC
- Ambiguity in the wording and examples regarding obstacle color HOT 2
- Trip Wire Draw Rule Disparity HOT 1
- Dismounted Individual Leadership Amplifier HOT 2
- Drawing SVGs and viewbox/crop area HOT 6
- Symbols do not scale as expected
- Update to MIL-STD-2525 revision E
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joint-military-symbology-xml.