Unique IDs not always unique about joint-military-symbology-xml

[csmoore]

Assigning to @abouffard

[csmoore]

Just an update on this - if we treat the unique IDs as strings (rather than numbers where the leading "0"'s get removed), then we get far fewer repeats.

Then the only collisions/exceptions for this case are the Exercise Frame IDs, so in order to get this resolved now, can we just add an "X" to the ID for all of the Exercise frame IDs. ex 1015 --> 1015X. This is only needed for the icon exports (so doesn't need to affect/change the domain exports).

Here is the list of repeats if the unique IDs are treated as strings:

Category	Name	UniqueID
Frame	Frame : Exercise : Pending : Land Equipment	1015
Amplifier : HQTFFD	HQTFFD : Unknown : Air : Feint/Dummy Task Force	1015
Frame	Frame : Exercise : Unknown : Air	1101
Amplifier : HQTFFD	HQTFFD : Unknown : Land Unit : Feint/Dummy	1101
Frame	Frame : Exercise : Unknown : Space	1105
Amplifier : HQTFFD	HQTFFD : Unknown : Land Unit : Feint/Dummy Task Force	1105
Frame	Frame : Exercise : Assumed Friend : Air	1201
Amplifier : HQTFFD	HQTFFD : Unknown : Land Installations : Feint/Dummy	1201
Frame	Frame : Exercise : Assumed Friend : Space	1205
Amplifier : HQTFFD	HQTFFD : Unknown : Land Installations : Feint/Dummy Task Force	1205
Frame	Frame : Exercise : Friend : Air	1301
Amplifier : HQTFFD	HQTFFD : Unknown : Sea Surface : Feint/Dummy	1301
Frame	Frame : Exercise : Friend : Space	1305
Amplifier : HQTFFD	HQTFFD : Unknown : Sea Surface : Feint/Dummy Task Force	1305

[abouffard]

In consulting with Mike Epler, we've decided to alter the names of the Frame SVGs to include an underscore.

Frames\Exercise\1_101.svg

He doesn't want to add letter characters to the names and no other digit added to them makes sense to him and he does want to make it possible to put all of the svgs in one flat folder, if that is the users desire, so uniqueness is important to him.

The unique names in our system don't necessarily HAVE to match the file names, but if we're thinking about adding a character to the Frame names anyway, why not comply with his new file names and use an underscore in the name.

I'm going to go ahead and change all the Frame names on our end, in the repo, and he is going to change his version. He is still working on cleaning up all the control measure graphics.

[csmoore]

The appending "X" was just a suggestion to get this issue moving along, but whatever unique scheme that is easily derivable is fine.

I guess in your description above, the scheme for frames is just being modified to add an "_" after digit 1 - e.g. (after) "1_101" (before) "1101" - so sounds like this is only a minor impact.

Just update this issue when you have a new set of SVGs/icon files available.

[abouffard]

Renamed Frame svgs and ensured Frame unique IDs are in fact unique. Changed "abcd" to "a_bcd".(inserted underscore between first and second digits). Done in #74

[csmoore]

Using/testing datasets available on 6/20, and treating all IDs as strings (so leading "0"'s are significant) - IDs look unique now.