Comments (10)
Just a comment - I realize some of these issues were already included in #90 (though that hasn't been updated for a while) - but for this issue I just listed the required changes that will be needed prior to the next csv/style generation
from joint-military-symbology-xml.
Thanks Chris. Shouldn't be a problem.
from joint-military-symbology-xml.
Just an FYI, I'm putting together the steps to use this now, so I added the assumed new field name for the unique Id column to add to the icons files to Step 1 above: styleItemUniqueId
from joint-military-symbology-xml.
Understood. I've added the styleItemUniqueId and styleItemGeometryType fields in between styleItemTags and notes. The change will be in my next PR/merge.
from joint-military-symbology-xml.
@abouffard not sure when you added the comment above (but I only just noticed - so apparently you don't get notifications so try to avoid editing someone else's comment items): So repeating here:
Question:
@csmoore - above, you mention the need for additional MOD1 and MOD2 values to "fill in", so the tags can be adequately parsed. Since I'm about to produce a version that contains 2525C SIDCs as one of the tags, can I assume that you also need a "fill in" for when a given 2525D symbol has no equivalent 2525C SIDC, to ensure the tags can be parsed. Something like. "NEW_TO_2525D" or "NOT_IN_2525C"?
Answer: sounds like a good idea to me, so long as we can easily remove that "NEW_TO_2525D" tag if someone complains/doesn't like
from joint-military-symbology-xml.
For the question above, if the 2525C tag is optional/not always set you can also put it as the last tag in the list (reverse order):
{2525C - Optional},IconType,Geometry,Name,ID
from joint-military-symbology-xml.
@abouffard the "add IconType enumeration for all entries" task is marked as done above, but I don't see an icon type entry for the Modifiers in the icon csv's
Looks like this may be ready to verify otherwise (don't forget to add an issue note & assign/label to verify when something is ready/done)?
from joint-military-symbology-xml.
Fixed in #121
from joint-military-symbology-xml.
Manually spot checked a few and these all look done.
The only thing I'm not sure about now that I see the output is all of those "SIDC_IS_NA"
ones (since the name/tag is a bit cryptic & is particularly confusing on the modifiers/amplifiers). Also the order which might be better as listed in one of the comments above: {2525C - Optional in case we want to drop that SIDC_IS_NA tag},IconType,Geometry,Name,ID
For the new (entity icon) ones, I guess we can infer that "SIDC_IS_NA" means this is a new one at 2525D, so perhaps we could just tag it is such with something like "2525D_NEW" and then for the modifiers/amplifiers either just drop this 2525C SIDC tag - or give it a better name/tag like "2525C_IS_NA" (probably dropping would be better)
from joint-military-symbology-xml.
Closing this one and adding open comment above to open issue #86
from joint-military-symbology-xml.
Related Issues (20)
- 18-011-MC Add Battle Handover Line Control Measure
- 18-012-MC Add Forward Passage of Lines as a Tactical Mission Task
- 18-013-MC Add Rearward Passage of Lines as a Tactical Mission Task
- 18-014-MC Add Control Point Control Measure
- 18-015-AR Add Human Resources Symbology
- 18-011-UK Boundary Amplifier Clarification
- 18-012-UK Lines Amplifiers Clarification
- 18-XXX-UK SCP Approval Clarification
- 18-014-UK Planned Control Measure Symbol ID
- Draw Rules for Antitank Ditch and Wall HOT 6
- Empty Paths in SVGs HOT 1
- Additional Affiliations HOT 1
- Ship Area of Interest - Questions HOT 1
- Variation in SVG size for Control Measures and METOC
- Ambiguity in the wording and examples regarding obstacle color HOT 2
- Trip Wire Draw Rule Disparity HOT 1
- Dismounted Individual Leadership Amplifier HOT 2
- Drawing SVGs and viewbox/crop area HOT 6
- Symbols do not scale as expected
- Update to MIL-STD-2525 revision E
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joint-military-symbology-xml.