Coder Social home page Coder Social logo

Comments (5)

patrickarlt avatar patrickarlt commented on May 19, 2024

It might sound kinda excessive but I think each one should be a separate library just namespaced under Leaflet.

  • Leaflet.SquareMarker
  • Leaflet.CrossMarker
  • Leaflet.XMarker
  • Leaflet.DiamondMarker

I'm going off https://github.com/jdfergason/Leaflet.Ellipse as an example.

from esri-leaflet-renderers.

kneemer avatar kneemer commented on May 19, 2024

Sounds good, I noticed that they added a triangle marker in 10.1(?) so I can add that while I'm at it.

from esri-leaflet-renderers.

kneemer avatar kneemer commented on May 19, 2024

@patrickarlt - I created these in my repo for now with package.json files so that I could get them with npm. I then included them in my build process but it seemed weird to reference them within the node_modules folder. Is there a better way to do this?

from esri-leaflet-renderers.

kneemer avatar kneemer commented on May 19, 2024

The markers had so much shared code that I put them into one repo with a base class of the shared code and each marker is just responsible for the svg and canvas drawing.

from esri-leaflet-renderers.

kneemer avatar kneemer commented on May 19, 2024

Done for leaflet-1.0

from esri-leaflet-renderers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.