extract require/define replacement into own package about ember-cli-amd

[ffaubry]

@tomwayson I have re-structured the code into module following an idea from @ggayowsky.
It should help you reuse some parts.
Propose a PR if you need further modifications.

[ffaubry]

@tomwayson
To beat someone to the punch you need to deliver before the others... This is delivering after ember-ci-amd has been out for 3 years and solved the issue correctly!
And yes, it's probably not covering all the issues.

I remind you, that ember-cli-amd supports engines and auto import.
We have reworked the code to make the main parts as module. Up to you to get this in ember-esri-loader...

With a little effort the ember-cli-amd could also lazy loads AMD modules. Just have to implement a smart service...

[ffaubry]

That's what we do: https://github.com/Esri/ember-cli-amd/blob/master/lib/replace-require-and-define-filter.js
This is a plugin!
We could have released it as a plugin.
We are a subclass of const Filter = require('broccoli-filter');
broccoli-filter is a subclass of require('broccoli-plugin');

[tomwayson]

Looks like I'd move the identifiers and literals too.

[tomwayson]

Thanks @ffaubry!

Looks like somebody (Robert Jackson no less) has beaten us to the punch:

https://github.com/rwjblue/broccoli-derequire

Also, have you seen this:

https://github.com/richardaiko/ember-derequire

Sadly some of the open issues there make me suspect that those are not functionally on par w/ the level of replacement that is supported by this addon or even ember-esri-loader (which supports lazy engines).

One way or another I'd really like to centralize the find and replace logic and make it consistent.

[tomwayson]

Specifically I meant beat to the punch on the idea of moving things into a broccoli plugin.

[ffaubry]

Closing