Can this repo be made public? about distance-direction-addin-dotnet

[topowright-zz]

@lfunkhouser @nfeuerstein I have gotten clarification that we can make this repo public. It will be done.

[lfunkhouser]

Good point. Will look at the requirements to make this and the visibility-addin-dotnet repo public.

[topowright-zz]

@jmccausland Can you work with @csmoore to make this repo public?

[csmoore]

I gave this repo a quick look and didn't notice anything that would keep it from being made public (it actually looked very good).

It would be good to get a secondary repo owner identified (also in coordinate-conversion-addin ) - now while we are thinking about this.

Just let me know when you want me to have a closer look and request it be made public.

[topowright-zz]

This will be brought into the backlog to be ready to be pulling into sprint 9

[topowright-zz]

@csmoore Once we get some of the issues worked out with our refactoring we would like to make this repo public. This should be done in the coming days.
@jmccausland will you add me to the repo as the second person owning the repo? Currently I will be the person that will own each of the add-ins once our project is finished.

[csmoore]

Sure - just let me know when you would like me to have a look

[topowright-zz]

#120

Once this pull request has been merged we will have two POC's

[jmccausland]

@topowright @csmoore All merged, I have some updates to the readme to do on building since it now contains a project for Pro

[jmccausland]

@topowright @csmoore Ok, I've update the solution file to include the new library, I'm thinking we should leave Pro out of the readme until it is more stable. Some core issues with geodesic ellipse might not get fixed until 1.3 release.

Anything else before we make it public?

[csmoore]

I'll give it a quick review/check/test now.

If you aren't going to include the Pro stuff - then you might want to remove it from the Visual Studio Solution since the Pro SDK is currently a dependency

[csmoore]

I reviewed and made a few minor comments just to prove I look at it.

The only significant issue that should be fixed is to either add Pro SDK to the Readme as a developer build dependency or remove the project from the solution. Just let me know when that is done (in master branch) & I will make request.

[jmccausland]

The Arcmap solution that is documented in the readme doesn't have the Pro project.

[csmoore]

Perhaps I am doing something wrong or misunderstanding

Does the Visual Studio solution (.sln) in the master branch not have the Pro addin project included? If so, Pro+SDK should be listed as a dependency here (if you really want devs to build this now) https://github.com/ArcGIS/distance-direction-addin-dotnet/blob/dev/README.md#developers

[jmccausland]

https://github.com/ArcGIS/distance-direction-addin-dotnet/blob/master/source/DistanceAndDirection/ArcMapAddinDistanceAndDirection/ArcMapAddinDistanceAndDirection.sln

No Pro here

[csmoore]

OK - I see what I was doing wrong - I was opening the other solution (in the parent folder): https://github.com/ArcGIS/distance-direction-addin-dotnet/blob/master/source/DistanceAndDirection/DistanceAndDirection.sln

So I guess this is kind of my bad - but I'm probably not the only person who would be confused by this (even though the correct path is in the "cd" line of https://github.com/ArcGIS/distance-direction-addin-dotnet/tree/master#development-environment )

[topowright-zz]

This repo is now been made public

[topowright-zz]

@nfeuerstein please verify

[nfeuerstein]

Verified.