Bug: unhandled error in `lintFiles` with glob patterns when config is invalid about eslint

[mdjermanovic]

I can reproduce this. Any ideas how to fix it?

[fasttime]

Any ideas how to fix it?

We could catch the error in entryFilter and rethrow it after doFsWalk. Or we could call fswalk.walk inside a promise executor (instead of wrapping it with util.promisify), so we could reject the promise when entryFilter throws an error.

Finally, we could open an issue at nodelib and ask them to handle errors in their filter callbacks, so we don't have to. Upgrading to @nodelib/fs.walk 2.0.0 didn't help, and I couldn't find a closed issue in their repo that matches our problem.

[mdjermanovic]

Finally, we could open an issue at nodelib and ask them to handle errors in their filter callbacks, so we don't have to. Upgrading to @nodelib/fs.walk 2.0.0 didn't help, and I couldn't find a closed issue in their repo that matches our problem.

This seems like the best solution, but it will probably take some time. Can you open an issue there?

Or we could call fswalk.walk inside a promise executor (instead of wrapping it with util.promisify), so we could reject the promise when entryFilter throws an error.

This would be the easiest solution for us at the moment, though I wouldn't expect it to work if util.promisify doesn't, but let's try it.

[fasttime]

Thanks for the feedback @mdjermanovic.

Finally, we could open an issue at nodelib and ask them to handle errors in their filter callbacks, so we don't have to. Upgrading to @nodelib/fs.walk 2.0.0 didn't help, and I couldn't find a closed issue in their repo that matches our problem.

This seems like the best solution, but it will probably take some time. Can you open an issue there?

Sure!

Or we could call fswalk.walk inside a promise executor (instead of wrapping it with util.promisify), so we could reject the promise when entryFilter throws an error.

This would be the easiest solution for us at the moment, though I wouldn't expect it to work if util.promisify doesn't, but let's try it.

I can look into this and see what work works for us.

[nzakas]

Issue: nodelib/nodelib#105

[pumano]

got same error when using nx and config contains:

 languageSettings: { parserOptions: { project: ["./tsconfig.*?.json"] } }

looks like schema does not contain that field and error handling processed incorrectly (as mentioned above)

console output:

node_modules/@nx/eslint/node_modules/@humanwhocodes/object-schema/src/object-schema.js:270
                      throw new UnexpectedKeyError(key);
                      ^
      
      UnexpectedKeyError: Unexpected key "languageSettings" found.