Frontend tests about esfiddle

[patrick1011]

Hey,

I fancy giving this a bash if that's okay? I'm a first-timer but have done some test-writing before so think I'd be able to give this a decent shot!

Patrick

[tarang9211]

@joshghent & @patrick1011 I suggest using Mocha and Chai to test the front end also. We are using that at work, and it seems to do the job pretty well.

[joshghent]

@tarang9211 @patrick1011 Yeah use whatever framework is easiest. As long as they work!

[patrick1011]

Great - i'll use Mocha!

[patrick1011]

@joshghent @tarang9211 Just a quick update - I've written some tests in Mocha + Chai and Selenium to test the layout buttons and github links work. It's going well.

One question though: what would you say constitutes a test for the dropdowns? That the editor changes background colour/content based on what's clicked (themes/examples)?

[joshghent]

@patrick1011 I mean in an ideal world then we would make sure that the correct classes get applied when changing the theme, but I think if you just add a test for one theme and then check it works correctly (i.e., the class has been applied, it doesn't matter about the colors that the editor now is) will be fine, thanks :)

[joshghent]

@patrick1011 Hey there, have you had chance to work on this at all? It's ok if not, just want to check in and see if this is still in the works 👍

[tarang9211]

@patrick1011 sorry for being so late to the party. In such cases, I have tested for the presence of the class name and that works. Let me know if you run into any issues!

[joshghent]

@patrick1011 I'd advice using something like this http://nightwatchjs.org/
Mocha doesn't seem to have great syntax for checking css without mocking loads of stuff.

[SaraVieira]

@joshghent I think we should use mocha for the tests and then supercharge later with some CSS regression tests with https://github.com/Huddle/PhantomCSS

The idea is that I think those two things should be split, unit tests and layout tests, what do you think ?

[joshghent]

@SaraVieira Agreed, split them down. I agree with the different types of testing as well. Good to cover all aspects.

[SaraVieira]

I'll create an issue for the Regression tests and assign it to me, because I have been meaning to play with that for a while

@patrick1011 if you are still working on those mocha tests as unit tests that would be awesome and them I'll start on the CSS tests from the redesign branch

@joshghent

[joshghent]

Sounds good @SaraVieira. Look forward to hearing about your progress.

[collinmesser]

@patrick1011 are you still working on this one? If not, no worries, just let us know and I will probably take it over.

[joshghent]

@collinmesser Sorry I didn't pick up on this one. I'd say that it's free game. We'd love to get this checked off!

[AbubakarSaad]

Is this issue still open? or some testing still left in front-end? I would love to take a shot at it!
Abu

[joshghent]

@AbubakarSaad Yes sure thing! Go ahead! We'd love to have your help and would great appreciate this being done! 👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[joshghent]

@AbubakarSaad Hey there, I kind of let this issue drift but wanted to check in to see if you were doing ok with your PR and this issue? Can I or anyone else in the team help? Contact me on gitter if you need any assistance! 👍

If you no longer have time to work on it, that's fine too. We appreciate people generously donate their precious free time to this!