Something is up with the nuget. about gamefinder

[erri120]

I should have probably put this in the readme somewhere. In 1.6.4 I added support for Steam on Linux by changing the project file and adding some conditional code:

GameFinder/GameFinder.StoreHandlers.Steam/GameFinder.StoreHandlers.Steam.csproj

Lines 29 to 31 in 8c7c41e

	<ItemGroup Condition="'$(TargetFramework)' == 'net5.0-windows'">
	<ProjectReference Include="..\GameFinder.RegistryUtils\GameFinder.RegistryUtils.csproj" />
	</ItemGroup>

GameFinder/GameFinder.StoreHandlers.Steam/SteamHandler.cs

Lines 54 to 78 in 8c7c41e

	#if Windows
	using var steamKey = Microsoft.Win32.Registry.CurrentUser.OpenSubKey(SteamRegKey);
	if (steamKey == null)
	{
	Logger.LogError("Unable to open registry key {SteamKey}", steamKey);
	return;
	}
	var steamPath = RegistryUtils.RegistryHelper.GetStringValueFromRegistry(steamKey, "SteamPath", Logger);
	if (steamPath == null) return;
	if (!Directory.Exists(steamPath))
	{
	Logger.LogError("Path to Steam from Registry does not exist: {SteamPath}", steamPath);
	return;
	}
	#else
	var steamPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile),
	".steam", "steam");
	if (!Directory.Exists(steamPath))
	{
	Logger.LogError("Default Steam path for Unix systems does not exist: {SteamPath}", steamPath);
	return;
	}
	#endif

The idea is to use net5.0 if you are on Linux, in which case you either provide the path to the Steam folder or it will look for it in ~/steam/steam, or net5.0-windows which will also load the GameFinder.RegistryUtils lib and look for the Steam path in the registry.

[halgari]

So I can't use net5.0 on windows? In reality what I'm doing is testing everything on net6.0

…

On Mon, Aug 9, 2021 at 7:18 AM erri120 ***@***.***> wrote: I should have probably put this in the readme somewhere. In 1.6.4 I added support for Steam on Linux by changing the project file and adding some conditional code: https://github.com/erri120/GameFinder/blob/8c7c41e1460f4e4026b83565942528d065dc22a5/GameFinder.StoreHandlers.Steam/GameFinder.StoreHandlers.Steam.csproj#L29-L31 https://github.com/erri120/GameFinder/blob/8c7c41e1460f4e4026b83565942528d065dc22a5/GameFinder.StoreHandlers.Steam/SteamHandler.cs#L54-L78 The idea is to use net5.0 if you are on Linux, in which case you either provide the path to the Steam folder or it will look for it in ~/steam/steam, or net5.0-windows which will also load the GameFinder.RegistryUtils lib and look for the Steam path in the registry. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE72HPMG4E4FMXUYMGH6UTT37IRXANCNFSM5BZ7GSZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- “One of the main causes of the fall of the Roman Empire was that–lacking zero–they had no way to indicate successful termination of their C programs.” (Robert Firth)

[erri120]

The problem is that on Windows you'd need access to the registry and that comes from Microsoft.Win32.Registry which does not work on net5.0 or net6.0 and requries net5.0-windows or net6.0-windows. For unit tests I would recommend using the net5.0 package and making use of the other constructor where you can pass the location of Steam. You know where this is located on the build server so you don't need the registry to locate Steam.

I will also look at adding net6.0 as a target framework to the packages.

[halgari]

Ah that makes sense, okay I'll rework these tests a bit, I should be able to solve this with a platform switch (like you suggested) and a bit of DI magic

…

On Mon, Aug 9, 2021 at 7:45 AM erri120 ***@***.***> wrote: The problem is that on Windows you'd need access to the registry and that comes from Microsoft.Win32.Registry which does not work on net5.0 or net6.0 and requries net5.0-windows or net6.0-windows. For unit tests I would recommend using the net5.0 package and making use of the other constructor where you can pass the location of Steam. You know where this is located on the build server so you don't need the registry to locate Steam. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE72HIJJTHVTIFSAVOJDHLT37LVZANCNFSM5BZ7GSZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- “One of the main causes of the fall of the Roman Empire was that–lacking zero–they had no way to indicate successful termination of their C programs.” (Robert Firth)

[erri120]

Should be resolved in 2.0.0