yaws_rpc produces non-compliant jsonrpc results about yaws

[klacke]

I asked about this on the erlang list - but no response - from any json hackers.
Anyway - It looked as if this was the right thing - but the link above seems dead.
What shall I do ?

/klacke

[TBBle]

Which link is dead? The JSON-RPC specification link works for me still.

I don't see any way to attach patches to this bug tracker, but my changed code looks like:
encode_handler_payload({response, ErlStruct}, ID, RpcType) ->
StructStr =
case RpcType of
json -> json:encode({struct, [ {result, ErlStruct}, {id, ID}, {error, null}]});
haxe -> [$h, $x, $r | haxe:encode(ErlStruct)]
end,
{ok, StructStr}.

I've also got a patch that allows returning { error, ErlStruct } to fill in the error field in json-rpc or return an exception in haxe (untested). From the look of the yaws_rpc module, soap and soap_dime don't pass through this path.

One further enhancement I might play with is trying to catch exceptions coming out of the rpc call, and turn them into error results, so the really dumb python json-rpc client I'm testing with stops barfing on Yaw's 400 error page when its expecting a JSON-RPC result. ^_^

Would it be useful if I were to fork the project for these changes, or post patches to a mailing list or something?

[klacke]

Ok, I applied patch and pushed.
As for more ambitious hacks - by best the far is to git clone the yaws repo and then ask me to pull from your branch,

It's also ok to post patches - I can certainly live with that as well.

Thanks

/klacke