Coder Social home page Coder Social logo

Comments (6)

erikdarlingdata avatar erikdarlingdata commented on June 9, 2024 1

No problem at all! I'll have some time to kick it around tomorrow and get it tested/merged. Thank you for the submission.

from darlingdata.

erikdarlingdata avatar erikdarlingdata commented on June 9, 2024

Woah, neat! Big thumbs up from me. Pull request away.

from darlingdata.

billfinch avatar billfinch commented on June 9, 2024

@erikdarlingdata

Hey! Thanks for the approval! I just need permissions to push to the repo apparently:

$ git push -u origin 630-ADD-ESCAPE-to-Query-Text-Search
info: please complete authentication in your browser...
remote: Permission to erikdarlingdata/DarlingData.git denied to billfinch.
fatal: unable to access 'https://github.com/erikdarlingdata/DarlingData.git/': The requested URL returned error: 403

from darlingdata.

erikdarlingdata avatar erikdarlingdata commented on June 9, 2024

I'm not very familiar with Git from the command line, so I'm not sure what you're trying to do there. But no, I don't grant write privileges to anyone wishing to push changes in.

The usual process for people to work on code is to:

  • Fork the dev branch
  • Work on their local copy
  • Publish their branch
  • Create a Pull Request for me to merge in

There's a handy link in the contributing guide with more details, too: https://github.com/erikdarlingdata/DarlingData/blob/main/CONTRIBUTING.md

Thanks!

from darlingdata.

billfinch avatar billfinch commented on June 9, 2024

@erikdarlingdata

Got it, thanks! I am used to the GitHub Enterprise workflow we use in house with our own repositories, so I just needed to shift my paradigm to Open Source, LOL.

PR built and submitted!

from darlingdata.

erikdarlingdata avatar erikdarlingdata commented on June 9, 2024

Closed via #361

from darlingdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.