Coder Social home page Coder Social logo

Comments (5)

Firegarden avatar Firegarden commented on July 21, 2024

I have seen this before because I had the same issue. I believe I solved it by checking if the connection was stable before creating the offer. Eg.

pc.onnegotiationneeded = function () {
if (pc.signalingState === STABLE) {
trace('CreateOffer: ' + toUser);
pc.createOffer(function (offer) {

from bowser.

stefhak avatar stefhak commented on July 21, 2024

Bowser has the bug that the offer created by createOffer does not have any
fingerprint in it. A workaround is to do setLocal, and then send off the
pc.localDescription (which is an SDP with fingerprint info) to the other
side.

There is a PR to fix this bug,
EricssonResearch/openwebrtc#427, it seems I need
some help to get it reviewed and (hopefully) merged - perhaps you can say
you'd want this merged?

On Tue, Sep 22, 2015 at 5:17 AM, Robert Sherrill [email protected]
wrote:

I have seen this before because I had the same issue. I believe I solved
it by checking if the connection was stable before creating the offer. Eg.

pc.onnegotiationneeded = function () {
if (pc.signalingState === STABLE) {
trace('CreateOffer: ' + toUser);
pc.createOffer(function (offer) {

β€”
Reply to this email directly or view it on GitHub
#56 (comment)
.

from bowser.

Firegarden avatar Firegarden commented on July 21, 2024

I just can't remember how I resolved this. Now that you say that I feel
like I had to make sure I didn't actually use the offer or answer in my
signaling rather I used the pc.localdescription

pc.createOffer(function (offer) {
pc.setLocalDescription(offer,
function () {

_signalChannel.server.signalOffer(toUser, _userName, _connectionId,
JSON.stringify({ 'data': pc.localDescription })); // NOTE I am NOT passing
the offer.

pc.setRemoteDescription(new RTCSessionDescription(offer.data), function () {
pc.createAnswer(function (answer) {
pc.setLocalDescription(answer,
function () {

_signalChannel.server.signalAnswer(fromUser, _userName, _connectionId,
JSON.stringify({ 'data': pc.localDescription })); // I am NOT using the
answer again pc.localDescription

On Mon, Sep 21, 2015 at 7:34 PM, stefan hakansson [email protected]
wrote:

Bowser has the bug that the offer created by createOffer does not have any
fingerprint in it. A workaround is to do setLocal, and then send off the
pc.localDescription (which is an SDP with fingerprint info) to the other
side.

There is a PR to fix this bug,
EricssonResearch/openwebrtc#427, it seems I need
some help to get it reviewed and (hopefully) merged - perhaps you can say
you'd want this merged?

On Tue, Sep 22, 2015 at 5:17 AM, Robert Sherrill <[email protected]

wrote:

I have seen this before because I had the same issue. I believe I solved
it by checking if the connection was stable before creating the offer.
Eg.

pc.onnegotiationneeded = function () {
if (pc.signalingState === STABLE) {
trace('CreateOffer: ' + toUser);
pc.createOffer(function (offer) {

β€”
Reply to this email directly or view it on GitHub
<
#56 (comment)

.

β€”
Reply to this email directly or view it on GitHub
#56 (comment)
.

FIREGARDEN https://www.google.com/?q=firegarden
1877.222.7818

from bowser.

pearcetm avatar pearcetm commented on July 21, 2024

stefhak - I commented on the pull request. Is there any other place I should post to show support?

from bowser.

stefanalund avatar stefanalund commented on July 21, 2024

This should be fixed now. Please report back if the problem persists. Thanks.

from bowser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.