Write function outputs cite function as well as parameters about composure

[erichs]

Hi! Thanks for your interest in the project @mrazick and @5c0tt-b0t !

Actually, yes! I've verified that the presence of the hard-coded cite command on line 526 is cruft from a very early version of the script. It's not needed anymore. I'd welcome a PR to remove it!

EDIT: @mrazick: The reason that cite is hard-coded on line 526 in the write() function is to support an edge case using custom metadata. Imagine a user does:

myfunc() {
  cite candy
  candy twizzlers
}

This function depends on the presence of the cite function in the execution context myfunc resides in. The purpose of the write() function is to make it easier to transition from your shell to a written bash script. As it stands, if cite were not present on line 526, the output of the write command would be a script that would cause command not found: cite and command not found: candy errors if myfunc were invoked. By hard-coding this, we're saying it's better to have cite and not need it, than to need it and not have it. It's a bit of a trade-off.

@5c0tt-b0t: I'm not sure I follow what "if" statement you're referring to?

[nerd190]

Ok, just tested and it indeed fixes that problem! thanks @mrazick 👍
I was wondering if you knew (or better yet, the man himself @erichs)
whether this "if" statement at the top is neccessary?

for f in about author example group param version
do
  eval "$f() { :; }"
done
unset f

This also seems to be part of the actual composure.sh file,
Just wondering if this was needed (as it already in the composure script we have sourced) or in fact a bug???
Once I know, I can look into the script further and attempt to fix this if needed.
THANK YOU! @erichs Composure is amazing!!!