Coder Social home page Coder Social logo

Comments (5)

robmathews avatar robmathews commented on July 1, 2024 1

I just upgraded @myabc example to rails5 and tested it. Works fine, so I'd guess that remerging the files down would work. Here's my url - https://github.com/robmathews/where-or-example. So one of us should definitely look at the source files that have changed in the original commit, it would probably be short strokes to make the PR.

from where-or.

oyeanuj avatar oyeanuj commented on July 1, 2024

I am seeing the same issue. @myabc did you find a solution to this?

from where-or.

davidgeere avatar davidgeere commented on July 1, 2024

Exactly the same issue here, @myabc did you ever figure this one out?

from where-or.

bf4 avatar bf4 commented on July 1, 2024

I just saw this. I'm still using my patch in Rails 4.2.6 and am busy debugging other things right now ;) but how about take a look and see if any of the source files I've listed have changed in Rails 5 since I made the patch. If not, it might be a bug in Rails 5 :)

from where-or.

robmathews avatar robmathews commented on July 1, 2024

Seems that the where.or! patch failed to take into account that the preloader needs to merge the AST trees.

from where-or.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.