[100 SigmaUSD] `OraclePool` should only be instantiated once and passed to the users about oracle-core

[greenhat]

Also, not all users need the whole OraclePool struct. If only one or two properties are used, consider passing them instead.

[SethDusek]

I will work on this. Just to clarify, the goal is to make OraclePool instance static via lazy_static right?

[greenhat]

I thought about lazy_static, but I see it as a sort of "last resort". I mean it's essentially an immutable global var, which we cannot mock in tests. I'd prefer passing an instance as a parameter and if it gets too ugly, make it a lazy_static.

[hanbu97]

Do we need implement Sync for OraclePool first?

[greenhat]

Do we need implement Sync for OraclePool first?

Good question. I'd keep it as simple as possible. If it becomes too much of a hassle, we can pass only needed fields as arguments.

[hanbu97]

For simplicity, maybe a channel and spawned OraclePool can be introduced. But the performance will be limited to single thread(or multi by mpmc and multiple spawned). Do you have any good idea?

[greenhat]

For simplicity, maybe a channel and spawned OraclePool can be introduced. But the performance will be limited to single thread(or multi by mpmc and multiple spawned). Do you have any good idea?

Oh, it sounds way too complicated. It's essentially a bunch of parameters of simple types used to query the node. I mean, I'm not even sure that we need OraclePool to keep those "scans" together. I believe we can pass them directly to the interested parties. Also, *Scan types are not set in stone and can be altered if needed.

[greenhat]

The bounty is sent. Thank you!