RPC call doesn't use timeout when an erlang node is down [v1.2.2] about ergo

[Noksa]

Haha, sorry for that :)
And thanks a lot for your patience and help. Now it works!
I hope it was the last issue from me.

[halturin]

It seems the recent change caused this issue (Golang doc says we should read the channel if Stop() returns 'false', but it freezes in a certain case). Golang got a new timer behavior in the latest releases. It a bit confused me. Im going to fix it right away.

[halturin]

fixed and republished v1.2.2

[Noksa]

Oh thanks, you are so fast :)

[halturin]

just warming up before the work 😄

[Noksa]

I tried to remove the entire ~/go/pkg/mod directory and used go clean -modcache.
But I can't download the last version which was republished.
I even tried go get github.com/halturin/ergo@92cfd8f212cfef9ef2a9eb68dabbb7132bdb6f3a but still have the old version.

Do you know how I can download republished version?

PS: Dependencies in golang are evil...

[halturin]

It's weird. v1.2.2 points to 92cfd8f commit which is the latest one https://github.com/halturin/ergo/releases/tag/v1.2.2

Try to check out here $GOPATH/src/github.com

ps: might be it wasn't a good idea to update the release tag.

[Noksa]

Yeah, I can't figure out why golang still downloads previous version even if I use the latest commit's hash

[halturin]

I think i know. Along with go.mod there is go.sum which is points to the outdated commit. remove this file. it should be autogenerated.

[Noksa]

It didn't help :(

I also tried it within a docker container (so it is like a fresh install) and got the same behavior. It's really weird

[Noksa]

I found some info about republishing: https://golang.org/doc/modules/publishing

Note: Don't change a tagged version of a module after publishing it. 
For developers using the module, Go tools authenticate a downloaded module against the first downloaded copy. 
If the two differ, Go tools will return a security error. 
Instead of changing the code for a previously published version, publish a new version.

[halturin]

Just created a new tag - v1.2.2.1. Hope it fixes this problem.

[Noksa]

I think no 😄
Golang uses https://semver.org/ to version modules.
This version is incorrect and golang can't use it :(

[halturin]

what a beautiful day :). created another one - v1.2.3.

[halturin]

It's ok; it was my fault. I should have paid more attention making the new release. Thanks for your reports. They make 'ergo' stable and more solid.