Coder Social home page Coder Social logo

Comments (3)

nancikennedy avatar nancikennedy commented on June 20, 2024

I also checked his Venture Plan/Master Plan addons for other expansion "garrison" content and neither of those is causing this issue.

from wow-mission-report-button-plus.

erglo avatar erglo commented on June 20, 2024

Hi, thank you for reporting this!

I also checked his Venture Plan/Master Plan addons for other expansion "garrison" content and neither of those is causing this issue.

You're right, neither Venture Plan nor Master Plan is causing this issue. If War Plan is used in combination with either one of the others, MRBP also works. I looked into the code of WP and it is using a button hook. Your 3rd screenshot shows the WP menu. It is definitely not the MRBP menu; your settings are ok.
I assume that, since WP loads after MRBP, it simply overrides the minimap button hook. Apparently the WoW UI can only handle the last applied hook for the same UI widget.

I will try to find a way to add a possibility to manually reload the minimap button hook. I'm not sure if this is possible though. As far as I know, hooking into the WoW UI widgets only works during the UI loading process, but I might be wrong.

Currently you have only these three options:

  • either use MRBP and WP together with VP and/or MP,
  • or use MRBP without WP and/or VP/MP,
  • or rename the first letter of the MissionReportButtonPlus addon folder and the MissionReportButtonPlus.toc file in it to 'W', so it loads after WP. This also works. I just tried it.

from wow-mission-report-button-plus.

erglo avatar erglo commented on June 20, 2024

Hi, I fixed it. Re-registering the minimap button hooks went smoother than expected.
MRBP checks now after loading if War Plan is installed, and automatically re-registers the needed hooks. I tested it and it works with all 3 addons mentioned above.
In case this happens again, I also added a slash command. Should something similar happen again, simply type /mrbp hook and it re-registers the needed hooks.

Have fun!

from wow-mission-report-button-plus.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.