Comments (4)
In which file? Line 54 in idworker.py doesn't have and comparison.
from pysnowflake.
idworker.py:
Line 54: while last_timestamp == timestamp:
from pysnowflake.
Well you want to make sure you take the next bigger time so assuming time doesnt go backwards while the process is running == is more than fine.
There is a check when the process starts that time doesn't go backwards but you are correct that if someone changes the time backwards it may be an issue. The current code may fail if the time is smaller than the last time stamp.
This is basically a direct clone of the original snowflake code written in Scala. This was the code at the time I wrote it more than a year ago. I will check if this is the same in the original code as well.
Thanks for pointing that out.
from pysnowflake.
I've checked the original code and you are correct that it was <= instead ==.
I've fixed the code. Thanks!
from pysnowflake.
Related Issues (4)
- pysnowflake haven't any license HOT 1
- iworker.py line 78 HOT 2
- issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pysnowflake.