Line 54. "==" or "<=" ? about pysnowflake

[erans]

In which file? Line 54 in idworker.py doesn't have and comparison.

[zamster]

idworker.py:

Line 54: while last_timestamp == timestamp:

[erans]

Well you want to make sure you take the next bigger time so assuming time doesnt go backwards while the process is running == is more than fine.

There is a check when the process starts that time doesn't go backwards but you are correct that if someone changes the time backwards it may be an issue. The current code may fail if the time is smaller than the last time stamp.

This is basically a direct clone of the original snowflake code written in Scala. This was the code at the time I wrote it more than a year ago. I will check if this is the same in the original code as well.

Thanks for pointing that out.

[erans]

I've checked the original code and you are correct that it was <= instead ==.

I've fixed the code. Thanks!