got ERR_REQUIRE_ESM on implicit-children about types-react-codemod

[eps1lon]

Does it work with node 16?

[eps1lon]

I want to investigate this though. Tests are currently running on 14.x, 16.x, 17.x and 18.x so I'm missing something in the testing setup

[marwen-cherif]

Ah Thank you, it works on node 16
node 14 : KO
node 16 : OK
node 18 : KO

[eps1lon]

What's odd to me is why it would require C:\Users\dorki\WebstormProjects\reversio-front\node_modules\babel-preset-react-app\node_modules@babel\runtime\helpers\esm\toConsumableArray.js from C:\Users\dorki\AppData\Local\npm-cache_npx\07333c78fb78394f\node_modules\types-react-codemod\transforms\implicit-children.js

It reaches into your local node_modules from the global node_modules. That shouldn't be happening. So I'm probably not declaring some dependency correctly.

Edit: But then why is it importing some babel-runtime function from my transforms? Is codeshift transpiling the transforms? The published file does not contain any reference to toConsumeableArray: https://unpkg.com/browse/[email protected]/transforms/implicit-children.js

Edit2: I think I need to tell jscodeshift to not transform the transforms: facebook/jscodeshift#395 (comment). So the bug report actually revealed a potential optimization 🎉