Coder Social home page Coder Social logo

Comments (7)

stoyicker avatar stoyicker commented on May 29, 2024 1

Well, it seems prettier the way you initially suggested, and it may be a bit hidden for regular users that don't read this issue, but obviously as far as I am concerned, it's fine

from gitlab-merge-requests-lists-enhancer.

EpocDotFr avatar EpocDotFr commented on May 29, 2024

Hello, thank you for your interest!

Looks like you already can filter MRs depending on their WIP status:

Capture d’écran 2020-06-26 à 15 27 03

This filter has been introduced in GitLab 11.4.0.

About the latest pipeline status filter: I only took a quick look but looks like it's possible! I however can't give you a release date, though.

from gitlab-merge-requests-lists-enhancer.

EpocDotFr avatar EpocDotFr commented on May 29, 2024

Note: the GitLab API doesn't allow to filter MRs by pipeline status upwind. So the only possible thing I can do is to hide MRs based on the pipeline status although these MRs already have been displayed to the user.

from gitlab-merge-requests-lists-enhancer.

stoyicker avatar stoyicker commented on May 29, 2024

Sorry about the MR thing, this gitlab version got deployed to our infra literally the day after I wrote this xD Yeah I know about that limitation, but I think hiding them by directly altering the site to remove "out-filtered" ones should be fine. It's not like regular desktop gitlab users are going to be bothered about bandwidth and I don't know of any major mobile browsers that support add-ons.
I understand about the release date, thank you for your effort!

from gitlab-merge-requests-lists-enhancer.

EpocDotFr avatar EpocDotFr commented on May 29, 2024

Investigated a bit further: it's going to be very hard, and even impossible to hook into the filter component for several reasons. Too bad, would have been cool.

I however found another possible solution that is somewhat easier to implement: add a dropdown menu next to the sort dropdown menu:

image

The selected value would be remembered by storing it in the local storage.

from gitlab-merge-requests-lists-enhancer.

stoyicker avatar stoyicker commented on May 29, 2024

I'm no webdev at all and don't know what stack you're using, but I remember I did a chrome extension for google translate (https://github.com/stoyicker/Copy-Translation) where I just manipulated the site html directly, so I don't really see why you couldn't alter gitlab's filter to basically merge the dropdown you're proposing into it. But I don't know what stack you're using and barely any web development, so I think you should trust your own criteria. the dropdown solution looks perfectly fine to me

from gitlab-merge-requests-lists-enhancer.

EpocDotFr avatar EpocDotFr commented on May 29, 2024

Is it OK to put this pipelines status filter in the options page of the extension?

Adding this filter in the page itself (like in my above screenshot) means I have to write a system to persist preferences on a per-Gitlab-project basis, which is something I'd like to introduce later (because if I introduce such a feature, I'd like all the other options to be persisted the same way, which is a bit of work).

from gitlab-merge-requests-lists-enhancer.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.