Comments (6)
Done!
Thanks for the contributions! I'm not sure how everything's going to look for the workshops by the way. I'm pretty sure I want the whole workshop to be accomplishable even if folks know nothing about TypeScript and don't specify any types. So instructions shouldn't default to using types (though they can be added in addition to the primary examples which have no types).
I don't think I'll have any instructions for adding types in the comments of the exercises either. But the final version can definitely have the types.
Still playing around with all of this. And I really appreciate you taking time to make pull requests for things! Even if I don't merge those directly, they're a great reference if I get stuck 😅
from advanced-react-apis.
I think I'm ok with this solution. If you don't mind, I'd prefer to work on this myself until I have a good feel for how I want it all to work.
You can feel free to continue making PRs if you like, but it's more likely I'd use those as references as needed than actually merge them. I appreciate your willingness to help and I hope it's been an instructional experience for you as well! Thanks for all your help!
from advanced-react-apis.
FYI, I've decided to go with a different approach. I'm going to maintain a next
branch which will be the next version of the workshops. That's where I'll make all changes that I want to for the workshop (including new exercises/TypeScript/etc.). Then, when I re-record all the videos, next
will become main
and the old main
will get a special branch for historical reasons.
I think this'll be a lot easier to manage for everyone. If someone wants to try the TypeScript stuff, they can use the next
branch. They'll just have to accept that some of the code will be different from the videos until I get around to updating the videos.
from advanced-react-apis.
I agree.
I best the best course of action, in my opinion, would be to embrace the progressive enchantment approach;
- convert the base setup to leverage typescript (dependencies, tsconfig, .etc)
- maintain the exercises in JS (but also enabling them to switch to TS with zero friction)
- maintain the final IN JS
- provide the same finals also in Typescript.
The rationale behind it is that even developers writing JavaScript would be helped by the typescript implementation to better understand React's API, but not forced to switch to a different branch to see them.
To avoid confusion, the documentation for the typescript implementation could live within the typescript finals.
from advanced-react-apis.
@all-contributors please add @suddenlyGiovanni for ideas
from advanced-react-apis.
I've put up a pull request to add @suddenlyGiovanni! 🎉
from advanced-react-apis.
Related Issues (20)
- Warning not triggering from exercise 2, extra credit 3 HOT 1
- edit
- Another potential exercise 2 extra credit HOT 2
- Exercise 4 enhancement HOT 8
- Tests doesn't pass for `extra-1` in exercise 6 HOT 1
- Broken reference link in the documentation HOT 1
- Broken link to `How to contribute to open source`
- React team has removed the warning on setting `setState` on an unmounted component HOT 5
- Changelog HOT 1
- useContext gotchas HOT 1
- React DevTools only works on isolated page HOT 3
- Node 17 HOT 1
- Exercise 4 (useLayoutEffect: auto-scrolling textarea) -> no discernible difference between useEffect and useLayoutEffect in React 18
- useLayoutEffect: auto-scrolling textarea HOT 1
- Docker compose for advanced-react-hooks fails HOT 4
- useDebugValue - production deploys don't show anything HOT 2
- Please tell why did you say its still valuable to apply useSafeDispatch() function in your material even after react 18? HOT 1
- useDebugValue: useMedia (Advanced React Hooks) HOT 2
- [docs] Update repo docs pointing to react old link to new link.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from advanced-react-apis.