Coder Social home page Coder Social logo

Comments (4)

sorvell avatar sorvell commented on May 9, 2024

I believe the problem here is the use of the nofit: true setting. The intention is that the TouchScrollStrategy's client control fits tightly to the scrolling viewport so that it overflow and it scrolls. When nofit is set to true, this is not automatically the case.

It would be helpful to know what led to the use of nofit. Here's the intended use.

This setting is intended for rare cases when the scroller's dimensions cannot be directly specified on the Scroller control itself. For example, if the scroller's height should be constrained via css max-height then nofit should be set to true and the client control would be directly styled to have a max-height. (It should be noted that this use case is not documented and not currently well supported by the api since the client control is private to the scroller.)

Regardless of the use of nofit however, the suggested code change may be a reasonable simplification. While the styling issue remains for the cases noted above, this may help us eliminate the confusing nofit setting. We'll investigate.

from enyo.

onecrayon avatar onecrayon commented on May 9, 2024

Hm, I honestly don't remember why I ended up setting nofit: true. I suspect I added that when I was trying to figure out how to prevent overscrolling in iOS 5 (the overscroll on the entire document was driving me nuts before you pushed the fix for it), but when I went back and tested without nofit and using the latest Enyo code on GitHub rather than my scroll fixes, everything appears to be working in both iOS 5 and iOS 4.

So it looks like this is indeed only a problem when nofit is true.

FWIW, I also tested using the changes in my scroll-fixes branch without nofit being specified in my code, and that also worked so depending on the container for setting scroll position position and then switching to the client for overscroll might be a valid strategy to cover both use-cases.

Thanks for the help!

from enyo.

onecrayon avatar onecrayon commented on May 9, 2024

I've been testing my app with beta3 (and the latest few commits after beta3), and something has reverted. My source code is unchanged (still no nofit: true, no changes to CSS or Javascript otherwise), but it no longer scrolls correctly on iOS 4.3 unless I switch to using my scroll-fixes branch.

from enyo.

lishammel avatar lishammel commented on May 9, 2024

Closing out - issue quite old and not a priority to retest and assess current behavior.

from enyo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.