Comments (4)
I believe the problem here is the use of the nofit: true setting. The intention is that the TouchScrollStrategy's client control fits tightly to the scrolling viewport so that it overflow and it scrolls. When nofit is set to true, this is not automatically the case.
It would be helpful to know what led to the use of nofit. Here's the intended use.
This setting is intended for rare cases when the scroller's dimensions cannot be directly specified on the Scroller control itself. For example, if the scroller's height should be constrained via css max-height then nofit should be set to true and the client control would be directly styled to have a max-height. (It should be noted that this use case is not documented and not currently well supported by the api since the client control is private to the scroller.)
Regardless of the use of nofit however, the suggested code change may be a reasonable simplification. While the styling issue remains for the cases noted above, this may help us eliminate the confusing nofit setting. We'll investigate.
from enyo.
Hm, I honestly don't remember why I ended up setting nofit: true
. I suspect I added that when I was trying to figure out how to prevent overscrolling in iOS 5 (the overscroll on the entire document was driving me nuts before you pushed the fix for it), but when I went back and tested without nofit and using the latest Enyo code on GitHub rather than my scroll fixes, everything appears to be working in both iOS 5 and iOS 4.
So it looks like this is indeed only a problem when nofit is true.
FWIW, I also tested using the changes in my scroll-fixes branch without nofit
being specified in my code, and that also worked so depending on the container for setting scroll position position and then switching to the client for overscroll might be a valid strategy to cover both use-cases.
Thanks for the help!
from enyo.
I've been testing my app with beta3 (and the latest few commits after beta3), and something has reverted. My source code is unchanged (still no nofit: true
, no changes to CSS or Javascript otherwise), but it no longer scrolls correctly on iOS 4.3 unless I switch to using my scroll-fixes branch.
from enyo.
Closing out - issue quite old and not a priority to retest and assess current behavior.
from enyo.
Related Issues (20)
- wiki: myKind should be MyKind HOT 1
- wiki: enyo.List example outdated HOT 1
- Image isn't displayed when using an {{enyo/Image}} in its {{'contains'}} sizing mode (setting image as background for a div) in Chrome.
- npm zombie HOT 2
- Using XML-JS with EnyoJS HOT 3
- Can't start enyo project on webOS tv emulator HOT 1
- How to install a moonstone app template ? HOT 4
- Simplerepeater error HOT 1
- Collection is not showing up HOT 3
- How to pass and change data in SimpleRepeater ? HOT 3
- How to select element in DataRepeater ? HOT 1
- How to implement routing navigation enyojs ?? HOT 2
- How to implement google map api..?? HOT 1
- Can we use new ES6 standards HOT 1
- Using ares-webos-sdk in CI build HOT 1
- enyo-unselectable style fails on IE8 and 9 HOT 1
- WebService component doesn't work on IE9 & Windows Phone7 for cross site ajax calls HOT 6
- Enyo Needs a Compatibility Table HOT 8
- button animation difficulty with Android Browser HOT 1
- wiki: brace missing in start method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enyo.