Comments (5)
Would this pull request address your concern? #37
I'll likely be merging it this week.
from ubergraph.
Given the description, if @thenonameguy is using :auto-label true
as an option to viz-graph
, then that PR will not change what they are asking about.
I think it is this line of code they are referring to: https://github.com/Engelberg/ubergraph/blob/master/src/ubergraph/core.clj#L828
and they are hoping that the expression (if (keyword? n) (name n) n)
would instead be merely n
. That would also cause a slight change in behavior where the colon would now appear before all keywords, whether they had namespaces or not.
from ubergraph.
In my own experience, using name
on keywords makes the visualization far more readable, far less cluttered. Aside from the :
character, are there other formatting issues that make name
a problem for you?
from ubergraph.
@jafingerhut thanks, you are correct.
@Engelberg My use case is that I use the namespace feature as a "pseudo-attr" for my nodes.
:node-type-1/foo
:node-type-2/foo
, etc.
Since the namespace part is dropped via the name
fn the nodes are indistinguishable in viz-graph.
I would propose to use: (subs (str n) 1)
in place of (name n)
so that the colon is dropped. This way no breaking change is introduced and my use case is fulfilled.
from ubergraph.
That sounds reasonable to me.
from ubergraph.
Related Issues (20)
- Save as dot? HOT 4
- finding all nodes in all shortest paths HOT 2
- Call to ->Path is missing an argument? HOT 1
- IllegalArgumentException when requesting nodes in path HOT 20
- Bipartite returns false on clearly bipartite graph? HOT 11
- Perhaps more escaping help for ubergraph users? HOT 1
- Should removing a node from a graph also remove its attributes? HOT 5
- Questions for possible mention in ubergraph docs somewhere HOT 9
- find-edges returns edges with no metadata HOT 4
- Odd behavior for `(add-attr g e k v)` when `e` is edge object from different graph HOT 4
- Possible warning for documentation on attribute functions HOT 1
- Clojurescript pathfinding HOT 5
- Allow arbitrary additional keys in a graph? HOT 4
- Several implementations of graph algorithms that could be added to ubergraph.alg namespace HOT 2
- Does the implementation of other-direction need to call edge-description->edge ? HOT 1
- `topsort` doesn't work with multigraphs HOT 5
- Adding metadata produces wrong graph HOT 4
- Inits vs Manual Graph Creation Differences and find-nodes? HOT 2
- In Dorothy 0.0.7, save! moved to dorothy.jvm HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ubergraph.