Comments (3)
from django-rest-framework.
It's possible I interpreted the documentation wrong, but here it says
ALLOWED_VERSIONS. If set, this value will restrict the set of versions that may be returned by the versioning scheme, and will raise an error if the provided version is not in this set. Note that the value used for the DEFAULT_VERSION setting is always considered to be part of the ALLOWED_VERSIONS set (unless it is None). Defaults to None.
The "unless it is None" part refers to DEFAULT_VERSION
. Doesn't make sense for it to refer to ALLOWED_VERSIONS
because if it's None, anything is allowed.
This is also consistent with how other versioning schemes behave, see TestAcceptHeaderAllowedAndDefaultVersion.test_missing_without_default and TestAcceptHeaderAllowedAndDefaultVersion.test_missing_without_default_but_none_allowed. I added equivalent tests in TestNamespaceAllowedAndDefaultVersion
.
To fix the problem, you have to add None
to ALLOWED_VERSIONS
as shown in the unit tests.
I could be wrong but please review this again. You might be relying on incorrect, undocumented behavior. The API changes only make the behavior consistent with the documentation and with other versioning schemes.
from django-rest-framework.
Fair enough, it's actually not a big deal to make that change. The issue is more about the unexpected breakage, instead of going through the usual deprecation stages.
from django-rest-framework.
Related Issues (20)
- 3.15 not backwards compatible with 3.14 - "View' should either include a `queryset` attribute, or override the `get_queryset()` method." HOT 11
- 3.15 backward compatibility issue with 3.14 - `rest_framework.filters.SearchFilter.get_search_terms` returns `str` instead of `list` HOT 3
- New handling of default= for ModelSerializer HOT 6
- 3.15 regression: ListSerializer ValidationErrors silently changed return type
- 3.15 regression: ListSerializer ValidationError nested structure silently changed HOT 1
- 3.15 regression: UpdateModelMixin breaks views using Manager objects as queryset HOT 4
- Version 3.15.1 HOT 1
- 3.15(.1?) regression: optional fields in serializers are suddenly required (or need explicit None passed) HOT 11
- UniqueConstraint violation_error_message as error response in drf
- rest-framework Supports async class views ?
- 3.15 regression: Serializer validation failed for unique together constraint HOT 2
- Revert changes to `CursorPagination` that caused serious performance regression HOT 3
- Router.register cannot merge with urlpatters HOT 3
- UniqueTogetherValidator does not comply to Database standards
- HyperlinkedModelSerializer doesn't respect SECURE_PROXY_SSL_HEADER settings
- 3.15 is raising required error on model nullable fields HOT 6
- DRF generic views not fire post_save signal HOT 11
- [self-tests] cleanup order of `TestUrlPatternTestCase` HOT 1
- a question about BooleanField HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-rest-framework.