Comments (6)
@beribak I have created a new branch on origin: ui-fixup#50
You should fetch this branch, and dump the reactCameraRecorder branch.
git checkout -t origin/ui-fixup#50
After you fetch this, do an npm install
for good measure.
I have applied prettier, and merged in other changes, so that the only difference between this and master are the changes you have made to conversation-header.jsx and candidate-conversation.jsx
It should be for you, as it was before - but you need to check it.
You may also noticed I factored out another module - now lib/create-participant.js this is when candidate recording are uploaded. Shouldn't effect you.
Also - checkout portrait mode when there are only 3 candidates - there's one on the bottom row and two on the top row. I think they should all be on one row. Probably there should be only 1 row if there are 3 candidates or less.
Please see the new note in REAMDME.md about how to install prettier on VSC.
from undebate.
@beribak (Danko): Please provide a quick update in the comment section with below 4 key points before today's meeting for us to review:
- Progress
- Challenges / road blocks
- Expected completion date
- Availability during the week
from undebate.
- The only thing that is left is adding a scroll button when the videos go off the screen.
- 03/20/2020
- Every day between 12pm and 7pm
from undebate.
When I render at these dimensions, the left of the speaker and the right of the agenda are being clipped off. I think this has to do with recalculating the height of the speaking windows because it was going to be below the screen but that's a guess.
from undebate.
03/25: had call with Danko. Move it to Need testing. @beribak Danko will open up another issue "how to rearrange large number of things in screen"
from undebate.
Done in #125
from undebate.
Related Issues (20)
- UI/UX for alerting candidate that there is no audio HOT 4
- Recorder Instructions as React Component HOT 6
- Hangup still hears playback
- Hangup Button HOT 3
- Investigate using Google Civic Information API HOT 1
- Iframe for address lookup then candidate conversation
- Record Landscape Video while in Portrait Mode on Smartphone
- Candidate Lookup Page
- Load balancing on heroku HOT 1
- Prev Speaker, Prev Section shouldn't be active
- "Sitting there" recording task
- Candidate video showed twice
- Self-service Portal for Election Leaders to Create Undebates for their Election HOT 6
- customer recorder invite must use specified email HOT 2
- Rerecord countdown confusion
- Retry upload if error
- undebate creator doesn't put listening in the right spot
- Feedback function in footer.
- Portrait Mode header messed up
- Bad experience when PC doesn't have GPU
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from undebate.