A problem with get_(errors|infos)_array about codeigniter-aauth

[REJack]

not really, if $this->errors is empty it returns not FALSE it returns NULL so print_r(count($this->infos)); will return 0 and not 1

i've tested it with my Linux VPS and my Windows XAMPP same result.

[cekdahl]

I'm not sure what you did wrong but if you evaluate count(FALSE) you will see that this is in fact 1, and this is documented behavior. If you look in the session library you will see that flashdata is implemented using userdata, which is implemented like this:

function userdata($item)
{
    return ( ! isset($this->userdata[$item])) ? FALSE : $this->userdata[$item];
}

This means that if the item doesn't exist it will return FALSE, not NULL.

This problem arose from me using this library, so I had to trace the bug, i.e. I have also tested my conclusion.

[REJack]

we are both right
you tested it on CI 2.2
i tested it on CI 3

[cekdahl]

I guess you are behind the updates that cause the library to not work on CodeIgniter 2.x. I am of the opinion that we are not both right, and that @emreakay should not have accepted your pull request until it was made compatible with 2.x. It is clearly stated in the description of this library that it is for Codeigniter 2.x.

[cekdahl]

And, just to make sure I'm being understood, this is not legalism. I'm not just saying these things to be right. The problem is that when people such as I search for an authorization library for Codeigniter 2.x we're directed here, and start writing code in Codeigniter 2.x with this library thinking that it will work. But then when we run the code it turns out that it doesn't, and so we have to spend time to figure it out. I'm not saying the maintainers of this library cannot possibly drop support for 2.x - I'm just saying that it's evil to write that it's for 2.x when it's not compatible with 2.x.

[REJack]

@cekdahl i understood your opinion, can you close this issue? emre merged your PR and changed the Info Text to 2.x and 3.x

[cekdahl]

@REJack I forgot about that. It's now done.

[REJack]

thx 😃