SC.Button is not keyboard-accessible about ember.js

[mwcampbell]

The problem seems to be that SC.Button calls the designated action method in response to the mouseUp event, not the click event. The click event is synthesized when Space is pressed while the button has focus; this apparently is not so for the mouseUp event. So why is the action performed in response to mouseUp rather than click?

[mwcampbell]

I forgot to mention that I only tested this on Windows.

[bspaulding]

Just tested this in Chrome 16 on OSX 10.7.2, same issue.

[bspaulding]

Sorry for the mess, guys. I'm new to the pull request thing. :/

[MSch]

What I don't understand is why Ember needs to reimplement native behavior instead of just using the click event?

[bspaulding]

I agree, it seems more reasonable to expect the target's action to be triggered on the click event, rather than the mouseUp.

The unit tests for Ember.Button actually simulate this behavior via mouse down/up rather than click.

I'm working on a pull request to maintain other current behavior, but move the triggerAction call into the click handler. This will include updating the tests to simulate the different event.

[bspaulding]

However, I think its still reasonable to mimic 'isActive' behavior for mouse up/down on key up/down, (at least when key is space).

[tomdale]

This should be fixed now that we use click().