Comments (8)
So we've been looking at this area recently because of the Embroider upgrades, and I think the ember-cli behaviour is to not generate a test-support.css file if there are no addons that inject things (via classic addon behaviour). I suspect that this is happening now because there are no longer any addons that inject things into test-support.css, maybe ember-qunit recently changed to a v2 addon?
I don't know that we should just remove it from the blueprint, I think the better solution would be to generate it even when it is going to be empty, what do we think?
from ember-cli.
I was just trying to figure out where this gets built from. I'm pretty sure it's used somehow in ember-a11y-testing as invocations of a11yAudit
come with 404s every time looking for this file.
Edit - never mind this comes from axe-core
and can be turned off with
//test-helpers.js
import { setRunOptions } from 'ember-a11y-testing/test-support';
setRunOptions({
preload: false,
});
from ember-cli.
@NullVoxPopuli any thoughts?
from ember-cli.
It does seem like a bug with ember-cli.
Like, since ember-cli is the convention based build tool, it should probably gracefully fallback to an empty file for test-support.js, and log a message saying that no v1 addons put any content into it
At the same time, if ember-qunit was the only producer of test-support content, i think it's totally legit to just remove the entry from index.html
from ember-cli.
I don't see this on v5.7.0 or v5.5.0, is there something more specific than a new app to recreate it?
from ember-cli.
FWIW I've just created an addon following https://github.com/embroider-build/addon-blueprint?tab=readme-ov-file (I wanted to try to migrate my private addon to v2).
I have this error in the console when running the tests:
I don't know what is supposed to create this file, but as @NullVoxPopuli said, I guess I can just remove this file in the index.html
from ember-cli.
I don't see this on v5.7.0 or v5.5.0, is there something more specific than a new app to recreate it?
I just tried again, simply generating a new app with the latest ember-cli (5.8) through ember new
-> ember s
-> visit localhost:4200/tests
, it'll show an error for the test-support.css file. I think indeed we can simply remove it from the index.html blueprint.
from ember-cli.
So we've been looking at this area recently because of the Embroider upgrades, and I think the ember-cli behaviour is to not generate a test-support.css file if there are no addons that inject things (via classic addon behaviour). I suspect that this is happening now because there are no longer any addons that inject things into test-support.css, maybe ember-qunit recently changed to a v2 addon?
I don't know that we should just remove it from the blueprint, I think the better solution would be to generate it even when it is going to be empty, what do we think?
The only addons I knew of using this were ember-mocha (unsupported/deprecated) and ember-qunit before v2 conversion. Could be that there's others around indeed, so seems better.
from ember-cli.
Related Issues (20)
- Run Prettier standalone HOT 2
- fingerprint.prepend not working for the chunk js files HOT 3
- [email protected] has security vulnerability HOT 2
- Setup ESLint for gjs/gts
- You passed the '--typescript' flag but there is no TypeScript blueprint available. A JavaScript blueprint will be generated instead. HOT 7
- new typescript component blueprint gives eslint warning HOT 3
- Could it be possible to use `--directory` to output to an already existing directory? HOT 1
- Add a `--no-ci-provider` flag for `ember new`
- App blueprint has invalid ESLint config HOT 4
- Add bun support for Ember CLI projects HOT 1
- --port=4200 not working HOT 7
- Environment file is not loading accurately in CircleCI HOT 4
- Security vulnerability in lodash.template package HOT 2
- "hifi sourcemaps" don't work on a new Ember project HOT 2
- #9902 HOT 1
- Deprecation warning on Node 22 HOT 1
- qunit-dom is too old. current app uses v2, but v3 is a v2 addon.
- Lint dependencies are out of date.
- existing lint config too hard to use with gjs/gts, needs update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli.