Automatically uninstall JSHint about ember-cli-eslint

[BrianSipple]

There would definitely be a way to do that.

I really like the idea of removing ember-cli-jshint -- that would just be removePackageFromProject inside the afterInstall hook -- but I'd be a bit concerned about the extra step of zapping user files. Those can be precious! Perhaps only doing the uninstall and them keeping the instructions in the README about tending to your JSHint files would be the best compromise.

[alexlafroscia]

Makes sense to me! I just know that my first step with a new Ember app these days is to remove the JSHint addon and config, since my editor will automatically run JSHint if it can find the config file. You're totally right about not wanting to delete their files without permission though; I wonder if you could make it optional, the way installation of addons sometimes prompts the user if they want to override a file?

I'll put a PR together 😄

[Turbo87]

but I'd be a bit concerned about the extra step of zapping user files

there are several options for that:

• do nothing about it 😞
• delete every files that looks remotely like .jshintrc 😞
• tell the user he should manually delete all remaining .jshintrc files 😐
• show a list of found .jshintrc files to the user and ask him if the addon should remove them for him 😍

obviously all of that should only happen if .jshintrc files were found

[alexlafroscia]

That's a great idea! Would you want one "yes/no" or a prompt for each?

[Turbo87]

Maybe "yes/no/ask for each" initially but it think yes/no once should be enough too

[alexlafroscia]

@Turbo87 @rwjblue do you know how to test that these hooks (like the post-install one) work correctly? Would it run if I do

$ npm install alexlafroscia/ember-cli-eslint#whatever

Or better yet, it there a way to trigger these hooks with an addon that you have installed locally and are using npm link on?

[Turbo87]

do you mean ember generate ember-cli-eslint?

[alexlafroscia]

Ahh, yup. Hadn't even thought of that, that's exactly what I needed.

[ro0gr]

Looks like I'm too late to the party.
Shouldn't it be a responsibility of ember-cli-jshint addon to destroy its stuff?
Though I'm not sure if it's technically possible to call blueprint destroy from another blueprint's postInstall hook.

[madeeha-khan]

but I'd be a bit concerned about the extra step of zapping user files

there are several options for that:

• do nothing about it disappointed
• delete every files that looks remotely like .jshintrc disappointed
• tell the user he should manually delete all remaining .jshintrc files neutral_face
• show a list of found .jshintrc files to the user and ask him if the addon should remove them for him heart_eyes

obviously all of that should only happen if .jshintrc files were found

If you have installed using some package like npm, you can uninstall it by executing npm remove -g jshint