Support ESLint 2 about ember-cli-eslint

[chriskrycho]

Note: this is blocked by ember-cli/broccoli-lint-eslint#9, since it uses broccoli-lint-eslint under the hood. Once that updates, this will be able to be updated in straightforward fashion.

[ehntoo]

ESLint 2 will now be installed if you remove and re-install this package. ember-cli/broccoli-lint-eslint#9 has landed, and the dependency here is loosely-enough specified that it'll pull in the new version of broccoli-lint-eslint on a new install.

[chriskrycho]

Outstanding! I'll do just that on Monday and confirm it behaves as expected in our installation.

[chriskrycho]

Note for anyone else who runs into this on Ember in the next little bit. If you run into Error: Cannot find module 'estraverse-fb', there's another upstream issue affecting the interaction between babel-eslint and eslint proper, having to do with how Babel does some of the monkey-patching. If you're using babel-eslint (as you're likely to be if you're using ESLint and Ember CLI together), you need to do one of the following until the issue is resolved (hopefully this week):

• temporarily npm install estraverse-fb
• pin to "eslint": "~2.2.0" in your package.json

You'll want to track that upstream issue to know when to undo that temporary fix.

[chriskrycho]

@jonathanKingston tested and confirmed that (with the above qualifications noted) this is resolved. Please feel free to close!

[ehntoo]

@chriskrycho - I also ran into the estraverse-fb issues last night, and would like to highlight a third option. If your codebase sticks to ES6 and doesn't use any features that the standard eslint parser (Espree) doesn't support, you can stop using babel-eslint entirely. :)

[chriskrycho]

@ehntoo Oh, great point. We're using babel-eslint throughout a variety of projects, so not a great fit for us, but a good one in general.

[ehntoo]

Actually, as I'm dealing with this at work today, it'd be nice if we could get a new release of ember-cli-eslint explicitly pulling the new broccoli filter in so I can stop nuking this manually.

@jonathanKingston - is there anything I can help with to get a new release out?

[chriskrycho]

Update on the estraverse-fb issue: it should be resolved as of [email protected], so the underlying problem with babel-eslint should go away, I believe.

[alexlafroscia]

I was able to avoid the estraverse-fb issue by installing [email protected]

[BrianSipple]

Closed after ember-cli/broccoli-lint-eslint#28