Coder Social home page Coder Social logo

Comments (5)

takasehideki avatar takasehideki commented on May 26, 2024 1

@akampmann Thank you so much for answering my questions!
In my opinion, it can be tracked to the latest version in the following ways.

  1. fork eProsima/Micro-CDR into your organization embedded-software-laboratory
  2. remove the current embeddedRTPS/thirdparty/Micro-CDR directory
  3. add 1. as the submodule
  4. and then, checkout eProsima/Micro-CDR@62d95c8 (commit ID you copied)
  5. track some commits you added for embeddedRTPS https://github.com/embedded-software-laboratory/embeddedRTPS/commits/master/thirdparty/Micro-CDR

I think the report from @pablogs9 is very useful. Thanks!
We can use the latest version of Micro-CDR in embeddedRTPS as it is just by importing pablogs9@7a8b9a4


FYI: We decided to fix the issue of name conflict about #include <ucdr/types/string.h> that happened to support Mbed Web Compiler by changing the filename. Please check mROS-base#6
But we would be happy if you could track the latest version of Micro-CDR.

from embeddedrtps.

akampmann avatar akampmann commented on May 26, 2024 1

This branch contains the latest Micro-CDR release as a submodule and the changes suggested by @pablogs9

https://github.com/embedded-software-laboratory/embeddedRTPS/tree/feature/microcdr-submodule

Could you check if this works for you? Its compiling on my side, but will take a few days to run it on target platform for me.

from embeddedrtps.

akampmann avatar akampmann commented on May 26, 2024

Edit: We should definitely track the latest Micro-CDR if possible, we just have to figure out how to do this best.

Q1: I should be somewhere around this commit: eProsima/Micro-CDR@62d95c8

Q2: I absolutely don't mind adding Micro-CDR as a submodule. embeddedRTPS is currently used for a non-public project, where Micro-CDR is also used. Currently, the versions between embeddedRTPS and that other project match. I will have to double check what the necessary changes to the latest Micro-CDR project are. Does mROS itself also require changes to the latest Micro-CDR?

from embeddedrtps.

pablogs9 avatar pablogs9 commented on May 26, 2024

In micro-ROS we are using embeddedRTPS with mainline Micro-CDR. In this case, just using them as a CMake dependency managed with colcon. But I found a couple of problems when using latest version of our library. Maybe this commit can clarify something: pablogs9@7a8b9a4

from embeddedrtps.

akampmann avatar akampmann commented on May 26, 2024

Thank you both for your suggestions. I will have a look and come back about this.

from embeddedrtps.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.