Last commit broken the previous fix for Android R+ about instagram-ssl-pinning-bypass

[Eltion]

It's without the line. I think what is happening is that you're trying to patch an apk file where the resources.arsc is already compressed. You can try to install the apk without patching and if I'm correct it should not work.

In the picture above you can see that resources.arsc the method is STORE. It should be like this before and after patching.

[Eltion]

Sorry maybe I was a bit confusing. What I'm asking is that you maybe can check the original APK file if resources.arsc is compressed or just stored. If it is compressed then it won't work with the change that I did.

[Eltion]

Can you check my comment on the pull request: #3.
My idea was that for each file we will copy the compression method for the original apk. So if in the original apk the compression for resources.arsc is STORED it will be STORED also in the patched apk.

[michelerenzullo]

I cannot find your comment in the pull request?

Well I like that, this is the same idea that I used in my script, but as is written now it doesn't work.

You wanna do that? I think you have to copy and paste a duplicate of the original APK and update the archive overwriting the few patched files / inserting new files, without editing anything else, in this case I'm sure it will work because it works good for me since years without updating, I never encountered this bug.

I will show you how I would do that later.

[Eltion]

Can you help me test if the release from README.md is working for you?

[michelerenzullo]

Yes, the release works, but the question is did you create it without or with the line about resources.arsc? Because when I run the script without that line it doesn't install
Could you double check? Thanks

[michelerenzullo]

Ok, sorry for the waste of time, basically I thought, for mistake, that the link in the README.md was to the "original"/"unpatched" version and I was using the previous one (the broken one that you removed, zipped with Deflate) as input for patch_apk.py, so the output was Deflated as well. I download the original apk from a mirror and it works fine. I close

[michelerenzullo]

Sorry maybe I was a bit confusing. What I'm asking is that you maybe can check the original APK file if resources.arsc is compressed or just stored. If it is compressed then it won't work with the change that I did.

Yeah because you built the release the 22nd June, before the commit of 23rd June about "file.compress_type" and "apk_in.infolist()", I was using this version of 22nd June, patching an already patched apk(such a dumb).

The real solution was file.compress_type and was already on your repository.

[Eltion]

No problem this was actually my fault I forgot to submit my review of your pull request where I explained why I switched it back. Thanks for all the help :)