Coder Social home page Coder Social logo

Comments (2)

ElMassimo avatar ElMassimo commented on May 22, 2024 1

Hi Yann!

assetHost is intended for an external CDN host.

Hosting a Rails app in a nested path is unusual, but I think it makes sense to add a separate base setting in config/vite.json to support this use case.

{
  "all": {
     "watchAdditionalPaths": [],
  },
  "production": {
    "base": "my-app"
  }
}

Let me know if you would be willing to rework #152 to add the base setting instead of modifying the assetHost behavior.

const base = `${assetHostWithProtocol || config.base}/${config.publicOutputDir}/`

It would also make sense to allow configuring this setting using environment variables, like for other settings (VITE_RUBY_BASE=my_app). All it takes to implement that, is adding a default value for base:

  "base": "",

from vite_ruby.

ElMassimo avatar ElMassimo commented on May 22, 2024 1

Released [email protected] and [email protected] which add support for the base setting.

Run bin/vite upgrade to bump both dependencies.

Thanks! 😃

from vite_ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.