Coder Social home page Coder Social logo

Remove take_along_axis and take about nx HOT 5 OPEN

josevalim avatar josevalim commented on June 11, 2024
Remove take_along_axis and take

from nx.

Comments (5)

Benjamin-Philip avatar Benjamin-Philip commented on June 11, 2024 1

Yeah! To be clear, take can be replaced by gather (look at how EXLA does it) at the Nx level. take_along_axis also can be, but as an optional callback (again look at EXLA). Torchx has a simpler operation for take_along_axis

Thanks! I understood that from José's original wording as well.

from nx.

polvalente avatar polvalente commented on June 11, 2024 1

Torchx should have the specific implementation. EXLA and BinaryBackend can use the default that delegates to gather

from nx.

Benjamin-Philip avatar Benjamin-Philip commented on June 11, 2024

Could I have a stab at this?

from nx.

polvalente avatar polvalente commented on June 11, 2024

Yeah! To be clear, take can be replaced by gather (look at how EXLA does it) at the Nx level. take_along_axis also can be, but as an optional callback (again look at EXLA). Torchx has a simpler operation for take_along_axis

from nx.

Benjamin-Philip avatar Benjamin-Philip commented on June 11, 2024

Quick question: for which backend(s) do you want to implement the take_along_axis optional axis callback?

from nx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.