Consider having default locale set is a must about gettext

[josevalim]

Yes, Gettext.locale always need to return something. It may just default to "en".

[josevalim]

I am also wondering if the locale configuration should really be in Gettext.locale or if it should be per backend.

[lexmag]

locale configuration should really be in Gettext.locale or if it should be per backend

It feels more intuitive to have it per backend, and more flexible.

[whatyouhide]

I'm 👍 on making the locale per-backend. We can store it under MyApp.Gettext in the process dict and increment the arity of locale/0-1 to locale(backend) and locale(backend, locale). I'm not sure how we could configure it. We could use the Mix config for each backend:

config :my_app, MyApp.Gettext, default_locale: "pt_BR"

and also default to "en" if there's no config (which is the subject of the issue).

What do you think?

[josevalim]

👍 for everything. Will we also have MyApp.Gettext.locale/0/1?

[lexmag]

That sounds wonderful.

[whatyouhide]

@josevalim I wouldn't provide both Gettext.locale/1-2 and MyApp.Gettext.locale/0-1 because they would do the exact same thing (but we would still have to test/document all of them). Also, we'd need to introduce MyApp.Gettext.with_locale/2 as well. Wdyt?

[lexmag]

I do see the need for MyApp.Gettext.with_locale/2, not sure if we need MyApp.Gettext.locale/0-1 though.

[josevalim]

Ok, we don't need to add any of them. Gettext.get_locale(backend) & Gettext.put_locale(backend, ...) would be my votes. I think it would be nice to change the name so it is clearer now with multiple args and so we effectively break the users code, otherwise it can accidentally pass.

[whatyouhide]

Awesome, I'll come up with a PR soon.

[lexmag]

Ah, get_ and put_ verbs – that's nice. 😄

[whatyouhide]

I was 👍 for get_ and put_ from the beginning so I'm happy about this change :)