Unable to push to ECR repository about publish-docker-github-action

[santiDotIO]

I think at least this should be a documented for deploying ECR or the Github registry

Thank you for your swift response!

[elgohr]

I just updated the ECR action to use action.yml (as Dockerfile labels don't work since yesterday).
Could you please retry and also try a hardcoded registry?

[elgohr]

If that doesn't help, it would be great, if you could provide feedback on what happens, if you use the Docker from https://github.com/elgohr/ecr-login-action locally.
Sadly I can't help directly, as I'm not using ECR.

[santiDotIO]

I see the issues, the DOCKERNAME isn't prefixing the registry
https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/entrypoint.sh#L12

So here when you push it doesn't have a reference to the custom registry
https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/entrypoint.sh#L123

I think either need to add the registry to DOCKERNAME if registry is defined or add it to the push funtion

[elgohr]

Ok, so you were able to fix it by providing name with the registry?
I'm not sure about adding it in the action automatically, but I'll think about that. Sadly this would be a breaking change...

[elgohr]

Thank you for the feedback.
I think I'll add the registry, if the name doesn't contain it. In this way it wouldn't be breaking

[andrewcstewart]

Experiencing the same issue and not exactly following what the fix is? (or is it better to wait on an incoming update?)

[santiDotIO]

@elgohr recently publish an update, now it will work as expected when you define the registry attribute, so for example,

- name: Publish to Registry
      uses: elgohr/[email protected]
      with:
        name: `[BUCKET]`/`[IMAGE_NAME]`
        username: ${{ steps.ecr.outputs.username }}
        password: ${{ steps.ecr.outputs.password }}
        registry: `[ECR_REGISTRY_ID]`.dkr.ecr.us-east-1.amazonaws.com

the abvove will compile your image and also push to [ECR_REGISTRY_ID].dkr.ecr.us-east-1.amazonaws.com/[BUCKET]/[IMAGE_NAME]

Hope that helps

[andrewcstewart]

Hmm, I think I'm even more confused now. My ECR repo URI doesn't have two parts at the end:

[ECR_REGISTRY_ID].dkr.ecr.us-east-1.amazonaws.com/[BUCKET]/[IMAGE_NAME]

Unless that is supposed to be [ECR_REGISTRY_ID].dkr.ecr.us-east-1.amazonaws.com/[IMAGE_NAME]:[TAG] ??

Why is registry: ${{ steps.ecr.outputs.registry }} no longer valid?

My entire action looks like this:

name: docker
on: [push]
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - name: Login to ECR
      id: ecr
      uses: elgohr/ecr-login-action@master
      with:
        access_key: ${{ secrets.AWS_ACCESS_KEY }}
        secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        region: us-west-2
    - name: Publish to Registry
      uses: elgohr/[email protected]
      with:
        name: myregistry.dkr.ecr.us-west-2.amazonaws.com/myimage
        username: ${{ steps.ecr.outputs.username }}
        password: ${{ steps.ecr.outputs.password }}
        registry: ${{ steps.ecr.outputs.registry }}

[andrewcstewart]

Aha, I spoke too soon. I see the difference now.