grpc: Blocks and Minimum missing for feerate about lightning

[daywalker90]

Strange, i can see both floor and blockcount in the v23.11.2 node.proto

[michaelWuensch]

@daywalker90
Sorry for the unclear description. The problem is that it is missing in the primitives. I want to set the feerate for the withdraw endpoint, but cannot create a feerate object with the desired values to pass as input for the withdraw command:

lightning/cln-grpc/proto/primitives.proto

Lines 72 to 80 in 76cd323

	message Feerate {
	oneof style {
	bool slow = 1;
	bool normal = 2;
	bool urgent = 3;
	uint32 perkb = 4;
	uint32 perkw = 5;
	}
	}

[daywalker90]

Hm you mean like this?

def test_grpc_feerates(bitcoind, node_factory):
    LOGGER = logging.getLogger(__name__)
    """ Check that conversions of this rather complex type work.
    """
    grpc_port = reserve()
    l1, l2 = node_factory.line_graph(
        2,
        opts=[{"grpc-port": str(grpc_port)}, {}],
        announce_channels=True,  # Do not enforce scid-alias
    )
    l1.fundwallet(10_000_000)

    stub = l1.grpc
    feerates = stub.Feerates(clnpb.FeeratesRequest(style="PERKB"))
    LOGGER.info(f"{feerates}")
    newaddr = stub.NewAddr(clnpb.NewaddrRequest())
    LOGGER.info(f"{newaddr}")
    withdraw = stub.Withdraw(
        clnpb.WithdrawRequest(
            destination=newaddr.bech32,
            satoshi=clnpb.AmountOrAll(amount=clnpb.Amount(msat=500_000_000)),
            feerate=clnpb.Feerate(perkb=feerates.perkb.floor),
        )
    )
    LOGGER.info(f"{withdraw}")
    withdraw = stub.Withdraw(
        clnpb.WithdrawRequest(
            destination=newaddr.bech32,
            satoshi=clnpb.AmountOrAll(amount=clnpb.Amount(msat=500_000_000)),
            feerate=clnpb.Feerate(perkb=feerates.perkb.estimates[0].blockcount),
        )
    )
    LOGGER.info(f"{withdraw}")

Because that works for me.

[michaelWuensch]

Ah, thank you so much. This was my mistake.
With your help I was finally able to implement it in Java.