crash when channeld does not have short_channel_id about lightning

[dni]

we temporarily used this patch for the node not to immediately crash, and ran lighning-cli dev-forget-channel to remove the broken channels

diff --git a/lightningd/peer_control.c b/lightningd/peer_control.c
index ead4f76a2..d39058dba 100644
--- a/lightningd/peer_control.c
+++ b/lightningd/peer_control.c
@@ -1406,7 +1406,10 @@ static void peer_connected_hook_final(struct peer_connected_hook_payload *payloa
                        log_debug(channel->log, "Peer has reconnected, state %s: connecting subd",
                                  channel_state_name(channel));

-                       connect_activate_subd(ld, channel);
+                       if (strcmp(channel_state_name(channel), "CHANNELD_AWAITING_LOCKIN") != 0
+                          && strcmp(channel_state_name(channel), "CHANNELD_SHUTTING_DOWN") != 0) {
+                               connect_activate_subd(ld, channel);
+                       }
                }
        }

@@ -1799,6 +1802,9 @@ void peer_spoke(struct lightningd *ld, const u8 *msg)
                        log_debug(channel->log,
                                  "Reestablish on %s channel: using channeld to reply",
                                  channel_state_name(channel));
+                       if (strcmp(channel_state_name(channel), "AWAITING_UNILATERAL") != 0) {
+                               return;
+                       }
                        if (socketpair(AF_LOCAL, SOCK_STREAM, 0, fds) != 0) {
                                log_broken(channel->log,
                                           "Failed to create socketpair: %s",

[BitcoinJiuJitsu]

Open CLN bounty on this:
https://community.sphinx.chat/p/clt2n32tu2rjujq1jn6g/bounties/2158/2