Epiphany: Double-click in find bar opens new tab about browser

[janxkoci]

I can reproduce this bug in default elementary version of Epiphany, but it is not reproducible in snap version (currently 3.32.3), which has GNOME configuration instead of elementary patches and it also doesn't occur in the same version of Epiphany in Ubuntu 18.04 with GNOME.

[cassidyjames]

@janxkoci yeah it's caused by our patches, hence why it's in this repo. :)

[quequotion]

This is double click for new tab, and the problem isn't limited to the find bar.

This patch enables a double click in the find bar, on a tab close box, on an existing tab, or anywhere in the tab bar to open a new tab. It really ought to be limited, ie to just open space in the tab bar.

For comparison, in Files and Terminal, double click for new tab works only in open space in the tab bar (opens a new tab at ~/). Double click on an existing tab duplicates that tab. Double click on a close box does nothing. File's 'find' bar is inline with its 'path' bar; Terminal's pops up over the tab bar--neither seem prone to this issue.

[cassidyjames]

So it looks like it's on the "notebook" which includes every child widget, not just the "tab bar." Easy mistake. I don't see an actual tab bar widget, but I see an EphyEmbed widget that we don't want the double-click on, as it includes the web view and find bar at least.

[danirabbit]

We're no longer patching in the double click behavior so this is technically resolved