Coder Social home page Coder Social logo

Comments (8)

erickzhao avatar erickzhao commented on August 22, 2024 1

@malept Would probably be ideal to show progress using a Blueprint.js component in the Version Select right where the "Downloading" text is right now. As well, allow the download to be cancelled by hovering and clicking on the same area.

from fiddle.

malept avatar malept commented on August 22, 2024 1

As well, allow the download to be cancelled by hovering and clicking on the same area.

I'll need to think about how we can expose download cancellation so we can resolve #320. It seems problematic with the current implementation because we're using stream piping to write the HTTP response to a file.

from fiddle.

malept avatar malept commented on August 22, 2024

Improving is probably the better path but it might require splitting electron-download into multiple packages.

I'm interested in hearing what you think about what the new packages would be.

from fiddle.

felixrieseberg avatar felixrieseberg commented on August 22, 2024

@malept I'd love a module that simply handles the download (or maybe even just getting correct url to use), which could then be consumed by electron-download (with shell UI & co).

from fiddle.

malept avatar malept commented on August 22, 2024

I'd love a module that simply handles the download [...], which could then be consumed by electron-download (with shell UI & co)

It sounds like a simple electron-download-core ➡️ electron-download split to me. I was already thinking of replacing nugget with got + progress (or whatever progress bar module is in vogue right now), this would abstract it further.

from fiddle.

MarshallOfSound avatar MarshallOfSound commented on August 22, 2024

@malept @felixrieseberg I've rewritten electron-download a few times (and once with got) and I can never reach feature parity (especially things like proxy support). Not sure if that should be a massive concern but it's quite hard to match that proxy stuff

from fiddle.

malept avatar malept commented on August 22, 2024

I think that once we resolve electron/get#148, we can (finally) start working on this issue.

I'm interested to hear what folks think about how we should show download progress.

from fiddle.

erickzhao avatar erickzhao commented on August 22, 2024

Closed in #358, I believe.

We now use @electron/get and have a progress bar in our downloads.

from fiddle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.