Comments (8)
@malept Would probably be ideal to show progress using a Blueprint.js component in the Version Select right where the "Downloading" text is right now. As well, allow the download to be cancelled by hovering and clicking on the same area.
from fiddle.
As well, allow the download to be cancelled by hovering and clicking on the same area.
I'll need to think about how we can expose download cancellation so we can resolve #320. It seems problematic with the current implementation because we're using stream piping to write the HTTP response to a file.
from fiddle.
Improving is probably the better path but it might require splitting
electron-download
into multiple packages.
I'm interested in hearing what you think about what the new packages would be.
from fiddle.
@malept I'd love a module that simply handles the download (or maybe even just getting correct url to use), which could then be consumed by electron-download
(with shell UI & co).
from fiddle.
I'd love a module that simply handles the download [...], which could then be consumed by
electron-download
(with shell UI & co)
It sounds like a simple electron-download-core
➡️ electron-download
split to me. I was already thinking of replacing nugget
with got
+ progress
(or whatever progress bar module is in vogue right now), this would abstract it further.
from fiddle.
@malept @felixrieseberg I've rewritten electron-download
a few times (and once with got
) and I can never reach feature parity (especially things like proxy support). Not sure if that should be a massive concern but it's quite hard to match that proxy stuff
from fiddle.
I think that once we resolve electron/get#148, we can (finally) start working on this issue.
I'm interested to hear what folks think about how we should show download progress.
from fiddle.
Closed in #358, I believe.
We now use @electron/get
and have a progress bar in our downloads.
from fiddle.
Related Issues (20)
- `Follow Link` does not work in console or editor
- Handle missing local Electron.app
- Release links broken on electronjs.org HOT 1
- Confusing error if Gist contains invalid `package.json`
- Better UX for expired PAT for Gist publishing HOT 2
- Run from ASAR
- Endless 'Checking Status' Spinner when github release not found
- it does not open HOT 1
- Add the ZIP files to the releases
- cmd+k to clear the console HOT 2
- [Bug]: Electron fiddle downloads are 404ing
- Open/save dialog is not modal HOT 1
- Add support for .mts files in Jest configuration
- Notify new user about the default option : User data directory automatically deleted
- Electron Fiddle start fails with segmentation fault HOT 12
- SIGTRAP error on Ubuntu HOT 6
- arm64 deb will crash when opened HOT 2
- electron.exe for the current app doesn't kill once close or stop the app
- Windows 11 x64 23H2 Blank screen HOT 6
- Recommendation for fiddle uninstallation.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fiddle.