Support --help on atom command about electron

[kevinsawicki]

Yeah, I thought this worked but appears to have regressed, the current code is here

[zcbenz]

Currently the atom command uses open command to open the Atom in a new process and then quit immediately.

But application opened by open would be detached from terminal and its output would not be printed, if we want to make atom behave like other terminal editors correctly, we must execute Atom's binary directly instead of using the open command, so the atom command could keep running until the Atom application quits, just as if the --wait is always passed, @kevinsawicki is this change acceptable?

[aroben]

You can also use the -w flag to open to make it wait for the process to
quit.

On Tue, Aug 6, 2013 at 9:45 PM, Cheng Zhao [email protected] wrote:

Currently the atom command uses open command to open the Atom in a new
process and then quit immediately.

But application opened by open would be detached from terminal and its
output would not be printed, if we want to make atom behave like other
editors correctly, we must execute Atom's binary directly instead of using
the open command, so the atom command could keep running until the Atom
application quits, just as if the --wait is always passed, @kevinsawickihttps://github.com/kevinsawickiis this change acceptable?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/49#issuecomment-22224685
.

[zcbenz]

You can also use the -w flag to open to make it wait for the process to quit.

But the output of Atom would still not be printed.

[kevinsawicki]

I feel like this issue is more of an atom thing than an atom shell thing.

atom.sh could just change to parse command line flags and handle things like -h, etc. before it launches the main app.

I think we just need to pull some code out of main.coffee and do some of it up front before the app is opened.

[zcbenz]

Yeah parsing command line in atom.sh should be enough to fix this.

I duplicated this issue in atom: atom/atom#685, now I'm going to close this issue.