Can't close frozen window about electron

[zcbenz]

Atom-shell guarantees that closing window would trigger beforeunload and unload event in javascript, so an infinite loop would block the close event. Simply make the x on window work would break this guarantee.

I'll add a way to make browser aware of the infinite loop in renderer, so users can choose to (1) force closing the window; (2) continue waiting; (3) interrupt the loop and report the stack trace.

[kevinsawicki]

Yeah, a force close prompt would be great.

[nathansobo]

This appears to have regressed.

[nathansobo]

This appears to have regressed again.

[zcbenz]

@nathansobo I can not reproduce with following steps:

1. open devtools and run while(true);
2. click window's close button
3. wait for 5s and the Editor is not responding dialog shows

[nathansobo]

@zcbenz Strange. It's happening for me in certain specs, I think in situations where the spec pretty printer is trying to print way more than it can handle. If you put an endless loop in specs and run them, is it possible to reproduce?

[zcbenz]

Seems that the unresponsive dialog is suppressed in specs:
https://github.com/atom/atom/blob/master/src/browser/atom-window.coffee#L96

[nathansobo]

Wow, sorry about that.