app.browserWindow is not available when node integration is set to false about spectron

[kevinsawicki]

I'm sure there is a good reason for that

This is expected, the API helpers provided by Spectron run code in the renderer processes so if the browserWindow is unavailable then the helpers will not be able to run. app.browserWindow relies on calling require('electron').remote.getCurrentWindow() in the window which won't work if require is undefined.

This can be supported though, see https://github.com/electron/spectron#node-integration for more details on how to support this in your app.

Closing this out.

[DinisCruz]

thx, one issue is that node integration opens up a number of security concerns (i.e. the page we're opening can attack the local box and execute commands as the logged in user)

[kevinsawicki]

thx, one issue is that node integration opens up a number of security concerns

Yeah, I totally understand that, but hopefully running specs can be trusted and exposing the require function only to Spectron via a preload script is acceptable.

[watsoncj]

here's what i went with in a preload script:

if (remote.process.argv.indexOf('--insecure-test') > 1) {
    window.require = require;
}

[matt-buckley]

I have node integration enabled, yet app.browserWindow is still displaying as undefined. Are there any other known issues that might be causing this?

[cyruscook]

Thanks, this got me stuck!