Windows 7 32-bit : ZIP inconsistency about electron-prebuilt

[vikrantpogula]

Ok I seem to have figured out the issue by comparing with the prebuilt versions available here https://github.com/atom/electron/releases

It seems npm install -g electron-prebuilt is not including a default .asar archive (in this case atom.asar) in the resources folder. The following 2 folders are missing from the npm-install version and the .zip from electron releases page

 - resources
 - locales

Is this difference between the two intended ?
Might just be a issue with unzipping in electron-download

[mal]

Seems this is not exclusive to Windows, just got it on linux x64. Culprit looks to be the recent bump to the extract-zip module, it doesn't seem to extract directories correctly for the electron zips. Filed an issue: max-mapper/extract-zip#10.

[email protected]

 $ npm install

 > [email protected] postinstall /home/mal/code/mal/photon/node_modules/electron-prebuilt
 > node install.js

 [email protected] node_modules/extract-zip
 ├── [email protected]
 ├── [email protected]
 ├── [email protected] ([email protected], [email protected])
 ├── [email protected] ([email protected])
 └── [email protected] ([email protected], [email protected], [email protected])

 $ ll dist/
 total 93956
 -rw-r--r-- 1 mal mal  8743327 Sep 16 08:48 content_shell.pak
 -rwxr-xr-x 1 mal mal 58922768 Sep 16 08:48 electron
 -rw-r--r-- 1 mal mal 10206624 Sep 16 08:48 icudtl.dat
 -rw-r--r-- 1 mal mal   520152 Sep 16 08:48 libgcrypt.so.11
 -rwxr-xr-x 1 mal mal 16765152 Sep 16 08:48 libnode.so
 -rw-r--r-- 1 mal mal    31256 Sep 16 08:48 libnotify.so.4
 -rw-r--r-- 1 mal mal     1055 Sep 16 08:48 LICENSE
 -rw-r--r-- 1 mal mal   410849 Sep 16 08:48 natives_blob.bin
 -rw-r--r-- 1 mal mal   587068 Sep 16 08:48 snapshot_blob.bin
 -rw-r--r-- 1 mal mal        7 Sep 16 08:48 version

[email protected]

 $ npm install
 -
 > [email protected] postinstall /home/mal/code/mal/photon/node_modules/electron-prebuilt
 > node install.js

 [email protected] node_modules/extract-zip
 ├── [email protected]
 ├── [email protected]
 ├── [email protected]
 ├── [email protected] ([email protected], [email protected])
 ├── [email protected] ([email protected])
 ├── [email protected] ([email protected], [email protected], [email protected])
 └── [email protected] ([email protected], [email protected])

 $ ll dist
 total 93964
 -rw-r--r-- 1 mal mal  8743327 Sep 16 08:47 content_shell.pak
 -rwxr-xr-x 1 mal mal 58922768 Sep 16 08:47 electron
 -rw-r--r-- 1 mal mal 10206624 Sep 16 08:47 icudtl.dat
 -rw-r--r-- 1 mal mal   520152 Sep 16 08:47 libgcrypt.so.11
 -rwxr-xr-x 1 mal mal 16765152 Sep 16 08:47 libnode.so
 -rw-r--r-- 1 mal mal    31256 Sep 16 08:47 libnotify.so.4
 -rw-r--r-- 1 mal mal     1055 Sep 16 08:47 LICENSE
+drwxrwxr-x 2 mal mal     4096 Sep 16 08:47 locales
 -rw-r--r-- 1 mal mal   410849 Sep 16 08:47 natives_blob.bin
+drwxrwxr-x 3 mal mal     4096 Sep 16 08:47 resources
 -rw-r--r-- 1 mal mal   587068 Sep 16 08:47 snapshot_blob.bin
 -rw-r--r-- 1 mal mal        7 Sep 16 08:47 version

[max-mapper]

Thanks for the detailed bug reports, the issue has been fixed with extract-zip 1.1.1, so reinstalling electron-prebuilt should get the new working version