Coder Social home page Coder Social logo

Comments (7)

LongLiveCHIEF avatar LongLiveCHIEF commented on September 15, 2024

I was getting these errors also, but when I do the repro steps using your repo, It ran fine. (note, i ran it with node v 0.12.4)

from electron-prebuilt.

max-mapper avatar max-mapper commented on September 15, 2024

The only known bug I can think of that may be affecting this is max-mapper/extract-zip#6, which prevents some empty directories from getting extracted. I would be surprised if that was causing this though.

Also make sure you clear your cache in ~/.electron, it's possible its using a bad cached version from there too (thats another open issue #51)

from electron-prebuilt.

loveencounterflow avatar loveencounterflow commented on September 15, 2024

@maxogden interestingly, the issue you're pointing to mentions those *.lproj language files; it is exactly those that i have found to make the difference between an *.app downloaded by electron-prebuilt and ones that i manually downloaded.

I've updated the sample app (removed crash-reporter which caused an exception by itself; added some log statements to see which parts get executed) and cleaned the ~/.electron folder, but to no avail.

UPDATE I've just extracted the downloaded archive

~/.electron/electron-v0.30.6-darwin-x64.zip

by double-clicking on it, and moved it to

.../electron-sample-1/node_modules/electron-prebuilt/dist/Electron.app

overwriting the file that was there. That works! IOW there's not necessarily a difference between the archive that e-prebuilt downloads and the official release, it's the unpacking of that archive that likely gets it wrong.

IMHO both git and any archiver that ignores empty files and empty folders have a bug. After all, those tools should replicate application state as faithfully as possible. Saying that empty files and folders serve no purpose is wrong; if your app has a line if( fs.exists( ... ) ) that is as valid a statement about data in your program as any other and can make a difference, so all the empty stuff should be replicated as well.

from electron-prebuilt.

max-mapper avatar max-mapper commented on September 15, 2024

@loveencounterflow thanks for the investigation. Looks like if max-mapper/extract-zip#6 gets fixed then this issue will get fixed as well

from electron-prebuilt.

loveencounterflow avatar loveencounterflow commented on September 15, 2024

great news! (next someone should ask 1) why those empty *.lproj folders are there anyway and 2) why some part of the app crashes if they're not; i'd guess 1) they're not needed and 2) someone forgot to program forgivingly)

from electron-prebuilt.

smebberson avatar smebberson commented on September 15, 2024

@loveencounterflow electron/electron#2759

from electron-prebuilt.

max-mapper avatar max-mapper commented on September 15, 2024

fixed by 1.1.0 of extract-zip

from electron-prebuilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.