Coder Social home page Coder Social logo

Comments (6)

max-mapper avatar max-mapper commented on August 11, 2024

Sorry about that. To support this it looks like we would need to read .npmrc and if there is a http-proxy or https-proxy set we should pass it to the request options here: https://github.com/request/request#proxies

Should be pretty easy to implement. Patch welcome!

from electron-prebuilt.

uchidake avatar uchidake commented on August 11, 2024

Hi, all.
The request module supports http_proxy and https_proxy on environment variables.
https://www.npmjs.com/package/request#controlling-proxy-behaviour-using-environment-variables

I tried setting them and succeeded to install via proxy.

from electron-prebuilt.

max-mapper avatar max-mapper commented on August 11, 2024

@uchidake nice find! I added a note to the readme

from electron-prebuilt.

neocotic avatar neocotic commented on August 11, 2024

I think it would be better to support {{.npmrc}} settings since {{node install.js}} is kicked off as part of an "postinstall" npm script, meaning the install fails because of a proxy issue even if the {{.npmrc}} file contains all of the necessary proxy information.

It's not always just the proxy as well as the {{ca}} and/or {{cafile}} configurations might be required as well.

from electron-prebuilt.

max-mapper avatar max-mapper commented on August 11, 2024

this landed in electron-download 1.4.0

from electron-prebuilt.

Qilly avatar Qilly commented on August 11, 2024

I'm using 1.4.12 on Windows and still get exactly the same problem. I've set HTTP_PROXY and HTTPS_PROXY correctly (npm is using them to get to its server) but I still fail with a 403 in the electron post-build step. Any ideas?

from electron-prebuilt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.