Snapcraft builds are always auto rejected about electron-installer-snap

[RobbieTheWagner]

@malept I have been discussing this issue here https://forum.snapcraft.io/t/cannot-publish-an-electron-app/17493/25?u=rwwagner90 and debugging for many days. I still have yet to figure out a solution, but it seems if we made our build more like the one for electron-builder, it should work.

[davidwinter]

@mahnunchik might want to give @davidwinter/electron-forge-maker-snap a try in the meantime. @rwwagner90 and I have tested it with both of our apps, and it seems to be working well with the sandbox disabled.

[welcome]

👋 Thanks for opening your first issue here! If you have a question about using electron-installer-snap, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[RobbieTheWagner]

Looking into the code here further, it seems there is no way to disable the transform which adds browser-sandbox.

electron-installer-snap/src/yaml.js

Line 170 in 2f76307

'allow-sandbox': true,

How are we supposed to be able to do allow-sandbox: false?

[RobbieTheWagner]

@malept I tried to get a manual review and they gave me this response:

Use of the 'allow-sandbox' attribute of the browser-support interface is reserved for vetted publishers. 
Typically this access is not required (see https://forum.snapcraft.io/t/supported-interfaces/7744 for details). 

So it sounds like we need to be able to disable this. Does Electron require the sandbox to run on Linux?

[mahnunchik]

@malept any chance to have PR merged? #75

[RobbieTheWagner]

I can confirm that @davidwinter's project works great!

[VerteDinde]

Initial issue resolved in #141 - this should keep snaps from being auto-rejected by the snap store on the basis of browser-sandbox. Doing a little digging to make sure there isn't other issues that would result in an auto-reject, and then we can close this specific issue.